| Message ID | 20200526155909.5807-3-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6a29d134c04a8acebb7a95251acea7ad7abba106 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Fix WPA3 problems with b43 and b43_legacy | expand |
Larry Finger <Larry.Finger@lwfinger.net> writes: > Since the driver was first introduced into the kernel, it has only > handled the ciphers associated with WEP, WPA, and WPA2. It fails with > WPA3 even though mac80211 can handle those additional ciphers in software, > b43legacy did not report that it could handle them. By setting MFP_CAPABLE using > ieee80211_set_hw(), the problem is fixed. > > With this change, b43legacy will handle the ciohers it knows in hardare, > and let mac80211 handle the others in software. It is not necessary to > use the module parameter NOHWCRYPT to turn hardware encryption off. > Although this change essentially eliminates that module parameter, > I am choosing to keep it for cases where the hardware is broken, > and software encryption is required for all ciphers. > > This patch fixes a problem that has been in b43legacy since commit > 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx > devices"). > > Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> I'll do the same changes here as in patch 1.
On 5/27/20 7:39 AM, Kalle Valo wrote: > Larry Finger <Larry.Finger@lwfinger.net> writes: > >> Since the driver was first introduced into the kernel, it has only >> handled the ciphers associated with WEP, WPA, and WPA2. It fails with >> WPA3 even though mac80211 can handle those additional ciphers in software, >> b43legacy did not report that it could handle them. By setting MFP_CAPABLE using >> ieee80211_set_hw(), the problem is fixed. >> >> With this change, b43legacy will handle the ciohers it knows in hardare, >> and let mac80211 handle the others in software. It is not necessary to >> use the module parameter NOHWCRYPT to turn hardware encryption off. >> Although this change essentially eliminates that module parameter, >> I am choosing to keep it for cases where the hardware is broken, >> and software encryption is required for all ciphers. >> >> This patch fixes a problem that has been in b43legacy since commit >> 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx >> devices"). >> >> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> Cc: Stable <stable@vger.kernel.org> > > I'll do the same changes here as in patch 1. > Yes, both are OK. Larry
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices").
The bot has tested the following trees: v5.6.14, v5.4.42, v4.19.124, v4.14.181, v4.9.224, v4.4.224.
v5.6.14: Build OK!
v5.4.42: Build OK!
v4.19.124: Build OK!
v4.14.181: Build OK!
v4.9.224: Build OK!
v4.4.224: Failed to apply! Possible dependencies:
Unable to calculate
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c index 8b6b657c4b85..5208a39fd6f7 100644 --- a/drivers/net/wireless/broadcom/b43legacy/main.c +++ b/drivers/net/wireless/broadcom/b43legacy/main.c @@ -3801,6 +3801,7 @@ static int b43legacy_wireless_init(struct ssb_device *dev) /* fill hw info */ ieee80211_hw_set(hw, RX_INCLUDES_FCS); ieee80211_hw_set(hw, SIGNAL_DBM); + ieee80211_hw_set(hw, MFP_CAPABLE); /* Allow WPA3 in software */ hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_AP) |
Since the driver was first introduced into the kernel, it has only handled the ciphers associated with WEP, WPA, and WPA2. It fails with WPA3 even though mac80211 can handle those additional ciphers in software, b43legacy did not report that it could handle them. By setting MFP_CAPABLE using ieee80211_set_hw(), the problem is fixed. With this change, b43legacy will handle the ciohers it knows in hardare, and let mac80211 handle the others in software. It is not necessary to use the module parameter NOHWCRYPT to turn hardware encryption off. Although this change essentially eliminates that module parameter, I am choosing to keep it for cases where the hardware is broken, and software encryption is required for all ciphers. This patch fixes a problem that has been in b43legacy since commit 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices"). Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Stable <stable@vger.kernel.org> --- drivers/net/wireless/broadcom/b43legacy/main.c | 1 + 1 file changed, 1 insertion(+)