| Message ID | 20200724130658.GA29458@duo.ucw.cz (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | slimbus: ngd: simplify error handling | expand |
Pavel Machek <pavel@ucw.cz> writes: > Simplify error handling; we already know mwq is NULL. > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c I think you sent this to the wrong lists: $ scripts/get_maintainer.pl drivers/slimbus/qcom-ngd-ctrl.c Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT) Bjorn Andersson <bjorn.andersson@linaro.org> (maintainer:ARM/QUALCOMM SUPPORT) Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (maintainer:SERIAL LOW-POWER INTER-CHIP MEDIA BUS (SLIMbus)) linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT) alsa-devel@alsa-project.org (moderated list:SERIAL LOW-POWER INTER-CHIP MEDIA BUS (SLIMbus)) linux-kernel@vger.kernel.org (open list)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 743ee7b4e63f..3def0c782c7f 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1396,17 +1396,11 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) ctrl->mwq = create_singlethread_workqueue("ngd_master"); if (!ctrl->mwq) { dev_err(&pdev->dev, "Failed to start master worker\n"); - ret = -ENOMEM; - goto wq_err; + qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); + return -ENOMEM; } return 0; -wq_err: - qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); - if (ctrl->mwq) - destroy_workqueue(ctrl->mwq); - - return ret; } static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
Simplify error handling; we already know mwq is NULL. Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>