diff mbox series

nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage

Message ID 20200805153516.310cef625955.I0abc04dc8abb2c7c005c88ef8fa2d0e3c9fb95c4@changeid (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage | expand

Commit Message

Johannes Berg Aug. 5, 2020, 1:35 p.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

In nl80211_set_station(), we check NL80211_ATTR_HE_6GHZ_CAPABILITY
and then use NL80211_ATTR_HE_CAPABILITY, which is clearly wrong.
Fix this to use NL80211_ATTR_HE_6GHZ_CAPABILITY as well.

Fixes: 43e64bf301fd ("cfg80211: handle 6 GHz capability of new station")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rajkumar Manoharan Aug. 10, 2020, 3:32 a.m. UTC | #1
On 2020-08-05 06:35, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> In nl80211_set_station(), we check NL80211_ATTR_HE_6GHZ_CAPABILITY
> and then use NL80211_ATTR_HE_CAPABILITY, which is clearly wrong.
> Fix this to use NL80211_ATTR_HE_6GHZ_CAPABILITY as well.
> 
> Fixes: 43e64bf301fd ("cfg80211: handle 6 GHz capability of new 
> station")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  net/wireless/nl80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 19281d0c8c9d..bfda09d24146 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -6008,7 +6008,7 @@ static int nl80211_set_station(struct sk_buff
> *skb, struct genl_info *info)
> 
>  	if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
>  		params.he_6ghz_capa =
> -			nla_data(info->attrs[NL80211_ATTR_HE_CAPABILITY]);
> +			nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
> 
Thanks for the fix :). Must have overlooked.

-Rajkumar
diff mbox series

Patch

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 19281d0c8c9d..bfda09d24146 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -6008,7 +6008,7 @@  static int nl80211_set_station(struct sk_buff *skb, struct genl_info *info)
 
 	if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
 		params.he_6ghz_capa =
-			nla_data(info->attrs[NL80211_ATTR_HE_CAPABILITY]);
+			nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
 
 	if (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT])
 		params.airtime_weight =