diff mbox series

[01/28] wireless: intersil: hostap: Mark 'freq_list' as __maybe_unused

Message ID 20200819072402.3085022-2-lee.jones@linaro.org (mailing list archive)
State Accepted
Commit 34537d4924ba2a4e20d24b1d7e14530e6f741279
Delegated to: Kalle Valo
Headers show
Series Rid W=1 warnings in Wireless | expand

Commit Message

Lee Jones Aug. 19, 2020, 7:23 a.m. UTC
'freq_list' is used in some source files which include hostap.h, but
not all.  The compiler complains about the times it's not used.  Mark
it as __maybe_used to tell the compiler that this is not only okay,
it's expected.

Fixes the following W=1 kernel build warning(s):

 In file included from drivers/net/wireless/intersil/hostap/hostap_80211_tx.c:9:
 drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
 In file included from drivers/net/wireless/intersil/hostap/hostap_main.c:31:
 drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
 In file included from drivers/net/wireless/intersil/hostap/hostap_proc.c:10:
 drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
 In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
 from drivers/net/wireless/intersil/hostap/hostap_cs.c:196:
 At top level:
 drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
 In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
 from drivers/net/wireless/intersil/hostap/hostap_pci.c:221:
 At top level:
 drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
 In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
 from drivers/net/wireless/intersil/hostap/hostap_plx.c:264:
 At top level:
 drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]

Cc: Jouni Malinen <j@w1.fi>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/net/wireless/intersil/hostap/hostap.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Kalle Valo Sept. 1, 2020, 9:03 a.m. UTC | #1
Lee Jones <lee.jones@linaro.org> wrote:

> 'freq_list' is used in some source files which include hostap.h, but
> not all.  The compiler complains about the times it's not used.  Mark
> it as __maybe_used to tell the compiler that this is not only okay,
> it's expected.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  In file included from drivers/net/wireless/intersil/hostap/hostap_80211_tx.c:9:
>  drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
>  In file included from drivers/net/wireless/intersil/hostap/hostap_main.c:31:
>  drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
>  In file included from drivers/net/wireless/intersil/hostap/hostap_proc.c:10:
>  drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
>  In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
>  from drivers/net/wireless/intersil/hostap/hostap_cs.c:196:
>  At top level:
>  drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
>  In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
>  from drivers/net/wireless/intersil/hostap/hostap_pci.c:221:
>  At top level:
>  drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
>  In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
>  from drivers/net/wireless/intersil/hostap/hostap_plx.c:264:
>  At top level:
>  drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
> 
> Cc: Jouni Malinen <j@w1.fi>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

10 patches applied to wireless-drivers-next.git, thanks.

34537d4924ba hostap: Mark 'freq_list' as __maybe_unused
470d48c1c4c6 rsi: Fix some kernel-doc issues
2fc4c9ff1606 rsi: File header should not be kernel-doc
9833f5034597 libertas_tf: Demote non-conformant kernel-doc headers
25ced81e288d wlcore: cmd: Fix some parameter description disparities
9554663b8c57 libertas_tf: Fix a bunch of function doc formatting issues
6182abd858f7 iwlegacy: debug: Demote seemingly unintentional kerneldoc header
debdbb0c1b20 hostap: hostap_ap: Mark 'txt' as __always_unused
e2eb189e7660 cw1200: wsm: Remove 'dummy' variables
f696d724358c libertas: Fix 'timer_list' stored private data related dot-rot
diff mbox series

Patch

diff --git a/drivers/net/wireless/intersil/hostap/hostap.h b/drivers/net/wireless/intersil/hostap/hostap.h
index 8130d29c7989c..c4b81ff7d7e47 100644
--- a/drivers/net/wireless/intersil/hostap/hostap.h
+++ b/drivers/net/wireless/intersil/hostap/hostap.h
@@ -8,8 +8,10 @@ 
 #include "hostap_wlan.h"
 #include "hostap_ap.h"
 
-static const long freq_list[] = { 2412, 2417, 2422, 2427, 2432, 2437, 2442,
-				  2447, 2452, 2457, 2462, 2467, 2472, 2484 };
+static const long __maybe_unused freq_list[] = {
+	2412, 2417, 2422, 2427, 2432, 2437, 2442,
+	2447, 2452, 2457, 2462, 2467, 2472, 2484
+};
 #define FREQ_COUNT ARRAY_SIZE(freq_list)
 
 /* hostap.c */