diff mbox series

[-next,1/3] rtlwifi: rtl8723ae: fix comparison pointer to bool warning in rf.c

Message ID 20200910141642.127006-2-zhengbin13@huawei.com
State Accepted
Commit 4eef91a8dbcea1d699cd1de7d528520d6165b56c
Delegated to: Kalle Valo
Headers show
Series rtlwifi: rtl8723ae: fix comparison pointer to bool warning | expand

Commit Message

Zheng Bin Sept. 10, 2020, 2:16 p.m. UTC
Fixes coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:52:5-22: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:482:6-14: WARNING: Comparison to bool

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.26.0.106.g9fadedd

Comments

Kalle Valo Sept. 16, 2020, 6:12 a.m. UTC | #1
Zheng Bin <zhengbin13@huawei.com> wrote:

> Fixes coccicheck warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:52:5-22: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:482:6-14: WARNING: Comparison to bool
> 
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

3 patches applied to wireless-drivers-next.git, thanks.

4eef91a8dbce rtlwifi: rtl8723ae: fix comparison pointer to bool warning in rf.c
9d886ac4397e rtlwifi: rtl8723ae: fix comparison pointer to bool warning in trx.c
f26506f06bf8 rtlwifi: rtl8723ae: fix comparison pointer to bool warning in phy.c
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c
index ecec8c9f0992..b8ed80c84266 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c
@@ -49,7 +49,7 @@  void rtl8723e_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
 	if (rtlefuse->eeprom_regulatory != 0)
 		turbo_scanoff = true;

-	if (mac->act_scanning == true) {
+	if (mac->act_scanning) {
 		tx_agc[RF90_PATH_A] = 0x3f3f3f3f;
 		tx_agc[RF90_PATH_B] = 0x3f3f3f3f;

@@ -479,7 +479,7 @@  static bool _rtl8723e_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
 			break;
 		}

-		if (rtstatus != true) {
+		if (!rtstatus) {
 			rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
 				"Radio[%d] Fail!!\n", rfpath);
 			return false;