| Message ID | 20200915020330.96067-1-jingxiangfeng@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 41650c45fbd2d687c5d140be1779600d84201b72 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ssb: Remove meaningless jump label to simplify the code | expand |
Jing Xiangfeng <jingxiangfeng@huawei.com> wrote: > The out jump label has nothing to do. So remove it to simplify the code. > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 41650c45fbd2 ssb: Remove meaningless jump label to simplify the code
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c index 7c3ae52f2b15..dac54041ad8d 100644 --- a/drivers/ssb/pci.c +++ b/drivers/ssb/pci.c @@ -1164,17 +1164,12 @@ void ssb_pci_exit(struct ssb_bus *bus) int ssb_pci_init(struct ssb_bus *bus) { struct pci_dev *pdev; - int err; if (bus->bustype != SSB_BUSTYPE_PCI) return 0; pdev = bus->host_pci; mutex_init(&bus->sprom_mutex); - err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom); - if (err) - goto out; -out: - return err; + return device_create_file(&pdev->dev, &dev_attr_ssb_sprom); }
The out jump label has nothing to do. So remove it to simplify the code. Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/ssb/pci.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)