diff mbox series

[02/10] mt76: testmode: add snr attribute in rx statistics

Message ID 20201008112904.10620-2-shayne.chen@mediatek.com (mailing list archive)
State Superseded
Delegated to: Felix Fietkau
Headers show
Series [01/10] mt76: testmode: switch ib and wb rssi to array type for per-antenna report | expand

Commit Message

Shayne Chen Oct. 8, 2020, 11:28 a.m. UTC 
Support to display snr value when dumping rx statistics.

Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/testmode.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Felix Fietkau Oct. 11, 2020, 7:37 p.m. UTC | #1 
On 2020-10-08 13:28, Shayne Chen wrote:
> Support to display snr value when dumping rx statistics.
> 
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/testmode.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/testmode.h b/drivers/net/wireless/mediatek/mt76/testmode.h
> index 02c9495..4015f1d 100644
> --- a/drivers/net/wireless/mediatek/mt76/testmode.h
> +++ b/drivers/net/wireless/mediatek/mt76/testmode.h
> @@ -101,6 +101,7 @@ enum mt76_testmode_stats_attr {
>   * @MT76_TM_RX_ATTR_RCPI: received channel power indicator (array, u8)
>   * @MT76_TM_RX_ATTR_IB_RSSI: internal inband RSSI (array, s8)
>   * @MT76_TM_RX_ATTR_WB_RSSI: internal wideband RSSI (array, s8)
> + * @MT76_TM_RX_ATTR_SNR: signal-to-noise ratio (s32)
I think u8 makes more sense than s32 as a type for snr.

- Felix
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/testmode.h b/drivers/net/wireless/mediatek/mt76/testmode.h
index 02c9495..4015f1d 100644
--- a/drivers/net/wireless/mediatek/mt76/testmode.h
+++ b/drivers/net/wireless/mediatek/mt76/testmode.h
@@ -101,6 +101,7 @@  enum mt76_testmode_stats_attr {
  * @MT76_TM_RX_ATTR_RCPI: received channel power indicator (array, u8)
  * @MT76_TM_RX_ATTR_IB_RSSI: internal inband RSSI (array, s8)
  * @MT76_TM_RX_ATTR_WB_RSSI: internal wideband RSSI (array, s8)
+ * @MT76_TM_RX_ATTR_SNR: signal-to-noise ratio (s32)
  */
 enum mt76_testmode_rx_attr {
 	MT76_TM_RX_ATTR_UNSPEC,
@@ -109,6 +110,7 @@  enum mt76_testmode_rx_attr {
 	MT76_TM_RX_ATTR_RCPI,
 	MT76_TM_RX_ATTR_IB_RSSI,
 	MT76_TM_RX_ATTR_WB_RSSI,
+	MT76_TM_RX_ATTR_SNR,
 
 	/* keep last */
 	NUM_MT76_TM_RX_ATTRS,