| Message ID | 20201203033729.382088-2-zhouliangya@126.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> --- | expand |
zhouliangya@126.com wrote:
> From: lzhou <zhouliangya@126.com>
The subject and commit log is badly formatted, see patchwork link below.
But how is schedule_timeout_interruptible() better than msleep()?
Patch set to Changes Requested.
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 8ab262931dce..2941fbb6a412 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -3309,7 +3309,7 @@ int ath10k_pci_wait_for_target_init(struct ath10k *ar) /* Fix potential race by repeating CORE_BASE writes */ ath10k_pci_enable_legacy_irq(ar); - mdelay(10); + schedule_timeout_interruptible(msecs_to_jiffies(10)); } while (time_before(jiffies, timeout)); ath10k_pci_disable_and_clear_legacy_irq(ar);
From: lzhou <zhouliangya@126.com> --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)