diff mbox series

[next] wilc1000: remove redundant assignment to pointer vif

Message ID 20201203174316.1071446-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 9b0467ed9a7d9aa3b0ce6fb99715fc7c1be9782b
Delegated to: Kalle Valo
Headers show
Series [next] wilc1000: remove redundant assignment to pointer vif | expand

Commit Message

Colin King Dec. 3, 2020, 5:43 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The assignment to pointer vif is redundant as the assigned value
is never read, hence it can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/microchip/wilc1000/wlan.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ajay Singh Dec. 4, 2020, 6:39 a.m. UTC | #1 
On 03/12/20 11:13 pm, Colin King wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment to pointer vif is redundant as the assigned value
> is never read, hence it can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks.

Acked-by: Ajay Singh <ajay.kathat@microchip.com>

> ---
>  drivers/net/wireless/microchip/wilc1000/wlan.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
> index 993ea7c03429..c12f27be9f79 100644
> --- a/drivers/net/wireless/microchip/wilc1000/wlan.c
> +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
> @@ -685,7 +685,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
>                         if (!tqe_q[ac])
>                                 continue;
> 
> -                       vif = tqe_q[ac]->vif;
>                         ac_exist = 1;
>                         for (k = 0; (k < num_pkts_to_add[ac]) &&
>                              (!max_size_over) && tqe_q[ac]; k++) {
> --
> 2.29.2
>
Kalle Valo Dec. 7, 2020, 4:34 p.m. UTC | #2 
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment to pointer vif is redundant as the assigned value
> is never read, hence it can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>

Patch applied to wireless-drivers-next.git, thanks.

9b0467ed9a7d wilc1000: remove redundant assignment to pointer vif
diff mbox series

Patch

diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index 993ea7c03429..c12f27be9f79 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -685,7 +685,6 @@  int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
 			if (!tqe_q[ac])
 				continue;
 
-			vif = tqe_q[ac]->vif;
 			ac_exist = 1;
 			for (k = 0; (k < num_pkts_to_add[ac]) &&
 			     (!max_size_over) && tqe_q[ac]; k++) {