diff mbox series

rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism

Message ID 20201228082516.16488-1-pkshih@realtek.com (mailing list archive)
State Accepted
Commit 840105e4f12fa3aa5f5c3c5b42dacb82ab953289
Delegated to: Kalle Valo
Headers show
Series rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism | expand

Commit Message

Ping-Ke Shih Dec. 28, 2020, 8:25 a.m. UTC 
From: vincent_fann <vincent_fann@realtek.com>

Hal function must follow the value that calculates from dynamic mechanism.
Force to set new_lvl to 4 damages receiving ability. System will not able
to reconnect to the AP if wifi unexpected disconnecting at this moment.

Signed-off-by: vincent_fann <vincent_fann@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/rtw8821c.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Kalle Valo Jan. 11, 2021, 7:58 a.m. UTC | #1 
Ping-Ke Shih <pkshih@realtek.com> writes:

> From: vincent_fann <vincent_fann@realtek.com>
>
> Hal function must follow the value that calculates from dynamic mechanism.
> Force to set new_lvl to 4 damages receiving ability. System will not able
> to reconnect to the AP if wifi unexpected disconnecting at this moment.
>
> Signed-off-by: vincent_fann <vincent_fann@realtek.com>

The real name looks to be just a copy of username, badly configured git
maybe? I can fix it during commit, how does Vincent format his name in
regular email? Does this look ok:

Vincent Fann <vincent_fann@realtek.com>
Ping-Ke Shih Jan. 12, 2021, 2:16 a.m. UTC | #2 
On Mon, 2021-01-11 at 07:58 +0000, Kalle Valo wrote:
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > From: vincent_fann <vincent_fann@realtek.com>
> >
> > Hal function must follow the value that calculates from dynamic mechanism.
> > Force to set new_lvl to 4 damages receiving ability. System will not able
> > to reconnect to the AP if wifi unexpected disconnecting at this moment.
> >
> > Signed-off-by: vincent_fann <vincent_fann@realtek.com>
> 
> The real name looks to be just a copy of username, badly configured git
> maybe? I can fix it during commit, how does Vincent format his name in
> regular email? Does this look ok:
> 
> Vincent Fann <vincent_fann@realtek.com>
> 

Yes, it does.
Please help to fix it.

Thank you
---
Ping-Ke
Kalle Valo Jan. 14, 2021, 5:26 p.m. UTC | #3 
Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Vincent Fann <vincent_fann@realtek.com>
> 
> Hal function must follow the value that calculates from dynamic mechanism.
> Force to set new_lvl to 4 damages receiving ability. System will not able
> to reconnect to the AP if wifi unexpected disconnecting at this moment.
> 
> Signed-off-by: Vincent Fann <vincent_fann@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

840105e4f12f rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index fbfd85439d1f..74155c999ebb 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -1022,12 +1022,6 @@  static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
 	u8 pd[CCK_PD_LV_MAX] = {3, 7, 13, 13, 13};
 	u8 cck_n_rx;
 
-	if (dm_info->min_rssi > 60) {
-		new_lvl = 4;
-		pd[4] = 0x1d;
-		goto set_cck_pd;
-	}
-
 	rtw_dbg(rtwdev, RTW_DBG_PHY, "lv: (%d) -> (%d)\n",
 		dm_info->cck_pd_lv[RTW_CHANNEL_WIDTH_20][RF_PATH_A], new_lvl);
 
@@ -1044,7 +1038,6 @@  static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
 
 	dm_info->cck_fa_avg = CCK_FA_AVG_RESET;
 
-set_cck_pd:
 	dm_info->cck_pd_lv[RTW_CHANNEL_WIDTH_20][RF_PATH_A] = new_lvl;
 	rtw_write32_mask(rtwdev, REG_PWRTH, 0x3f0000, pd[new_lvl]);
 	rtw_write32_mask(rtwdev, REG_PWRTH2, 0x1f0000,