| Message ID | 20201228162839.369156-8-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wcn36xx: Enable downstream consistent Wake on Lan | expand |
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > Set a flag to indicate magic packet wakeup support on wcn36xx. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > drivers/net/wireless/ath/wcn36xx/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/main.c > b/drivers/net/wireless/ath/wcn36xx/main.c > index 579bb7f4db9c..cfa2e2d20a20 100644 > --- a/drivers/net/wireless/ath/wcn36xx/main.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -173,7 +173,7 @@ static struct ieee80211_supported_band wcn_band_5ghz = { > #ifdef CONFIG_PM > > static const struct wiphy_wowlan_support wowlan_support = { > - .flags = WIPHY_WOWLAN_ANY > + .flags = WIPHY_WOWLAN_ANY | WIPHY_WOWLAN_MAGIC_PKT > }; Shouldn't this be the last patch so that we don't enable the feature until it's fully implemented? This makes a difference when doing a bisect, for example.
On 11/01/2021 11:38, Kalle Valo wrote: > Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > >> Set a flag to indicate magic packet wakeup support on wcn36xx. >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> drivers/net/wireless/ath/wcn36xx/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c >> b/drivers/net/wireless/ath/wcn36xx/main.c >> index 579bb7f4db9c..cfa2e2d20a20 100644 >> --- a/drivers/net/wireless/ath/wcn36xx/main.c >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c >> @@ -173,7 +173,7 @@ static struct ieee80211_supported_band wcn_band_5ghz = { >> #ifdef CONFIG_PM >> >> static const struct wiphy_wowlan_support wowlan_support = { >> - .flags = WIPHY_WOWLAN_ANY >> + .flags = WIPHY_WOWLAN_ANY | WIPHY_WOWLAN_MAGIC_PKT >> }; > > Shouldn't this be the last patch so that we don't enable the feature > until it's fully implemented? This makes a difference when doing a > bisect, for example. > Sure, I'll add the flags from the subsequent patch and stack on-top so the enable is the last patch for magic packet and gtk rekey
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 579bb7f4db9c..cfa2e2d20a20 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -173,7 +173,7 @@ static struct ieee80211_supported_band wcn_band_5ghz = { #ifdef CONFIG_PM static const struct wiphy_wowlan_support wowlan_support = { - .flags = WIPHY_WOWLAN_ANY + .flags = WIPHY_WOWLAN_ANY | WIPHY_WOWLAN_MAGIC_PKT }; #endif
Set a flag to indicate magic packet wakeup support on wcn36xx. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)