| Message ID | 20210205180054.1031-1-nicolas.cavallari@green-communications.fr (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | wireless-regdb: Do not hardcode 'sforshee' in the certificate commonName | expand |
On Fri, Feb 05, 2021 at 07:00:54PM +0100, Nicolas Cavallari wrote: > gen-pubcert.sh hardcodes the 'sforshee' common name when generating the > certificate. Make it depend on REGDB_AUTHOR instead, which defaults to > $(whoami). > > Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> Applied, thanks!
diff --git a/Makefile b/Makefile index 2f1ed93..02176ec 100644 --- a/Makefile +++ b/Makefile @@ -80,7 +80,7 @@ $(REGDB_PUBKEY): $(REGDB_PRIVKEY) $(REGDB_PUBCERT): $(REGDB_PRIVKEY) @echo "Generating certificate for $(REGDB_AUTHOR)..." - ./gen-pubcert.sh $(REGDB_PRIVKEY) $(REGDB_PUBCERT) + ./gen-pubcert.sh $(REGDB_PRIVKEY) $(REGDB_PUBCERT) $(REGDB_AUTHOR) @echo $(REGDB_PUBKEY) > .custom diff --git a/gen-pubcert.sh b/gen-pubcert.sh index 1a4d579..a7e8538 100755 --- a/gen-pubcert.sh +++ b/gen-pubcert.sh @@ -1,7 +1,7 @@ #!/bin/bash -if [[ $# -ne 2 ]]; then - echo "Usage: $0 priv-key out-file" +if [[ $# -ne 3 ]]; then + echo "Usage: $0 priv-key out-file common-name" exit 1 fi @@ -13,6 +13,6 @@ openssl req -new -key "$1" -days 36500 -utf8 -nodes -batch \ string_mask = utf8only prompt = no [ req_distinguished_name ] - commonName = sforshee + commonName = $3 EOF )
gen-pubcert.sh hardcodes the 'sforshee' common name when generating the certificate. Make it depend on REGDB_AUTHOR instead, which defaults to $(whoami). Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> --- Makefile | 2 +- gen-pubcert.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)