diff mbox series

iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha

Message ID 20210702223155.1981510-1-jforbes@fedoraproject.org (mailing list archive)
State Accepted
Commit 2f32c147a3816d789722c0bd242a9431332ec3ed
Delegated to: Kalle Valo
Headers show
Series iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha | expand

Commit Message

Justin Forbes July 2, 2021, 10:31 p.m. UTC
The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
This works fine with the existing driver once it knows to claim it.
Simple patch to add the device.

Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
---
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Justin Forbes July 9, 2021, 5:32 p.m. UTC | #1
On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
<jforbes@fedoraproject.org> wrote:
>
> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> This works fine with the existing driver once it knows to claim it.
> Simple patch to add the device.
>
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> ---

Just an update from the user with this hardware that I built a test kernel for:
"Still going strong w/ AX201, speed OK, on par w/ speeds on windows,
no crashes, no weird messages about the driver."

Justin
Jaehoon Chung Aug. 8, 2021, 11:09 p.m. UTC | #2
Hi

On 7/10/21 2:32 AM, Justin Forbes wrote:
> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> <jforbes@fedoraproject.org> wrote:
>>
>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>> This works fine with the existing driver once it knows to claim it.
>> Simple patch to add the device.
>>
>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>


Before sending patch, I have found same patch to solve the Wifi problem.
Is there any progress about this patch? 

I hope that this patch will be applied.

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung


>> ---
> 
> Just an update from the user with this hardware that I built a test kernel for:
> "Still going strong w/ AX201, speed OK, on par w/ speeds on windows,
> no crashes, no weird messages about the driver."
> 
> Justin
>
Jaehoon Chung Aug. 12, 2021, 10:26 p.m. UTC | #3
Hi

On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> Hi
> 
> On 7/10/21 2:32 AM, Justin Forbes wrote:
>> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
>> <jforbes@fedoraproject.org> wrote:
>>>
>>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>>> This works fine with the existing driver once it knows to claim it.
>>> Simple patch to add the device.
>>>
>>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>

If this patch is merged, can this patch be also applied on stable tree?

Best Regards,
Jaehoon Chung

> 
> 
> Before sending patch, I have found same patch to solve the Wifi problem.
> Is there any progress about this patch? 
> 
> I hope that this patch will be applied.
> 
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> 
> Best Regards,
> Jaehoon Chung
> 
> 
>>> ---
>>
>> Just an update from the user with this hardware that I built a test kernel for:
>> "Still going strong w/ AX201, speed OK, on par w/ speeds on windows,
>> no crashes, no weird messages about the driver."
>>
>> Justin
>>
> 
>
Kalle Valo Aug. 21, 2021, 1:34 p.m. UTC | #4
Jaehoon Chung <jh80.chung@samsung.com> writes:

> Hi
>
> On 8/9/21 8:09 AM, Jaehoon Chung wrote:
>> Hi
>> 
>> On 7/10/21 2:32 AM, Justin Forbes wrote:
>>> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
>>> <jforbes@fedoraproject.org> wrote:
>>>>
>>>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>>>> This works fine with the existing driver once it knows to claim it.
>>>> Simple patch to add the device.
>>>>
>>>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
>
> If this patch is merged, can this patch be also applied on stable tree?

Luca, what should we do with this patch?
Justin Forbes Aug. 25, 2021, 6:07 p.m. UTC | #5
On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Jaehoon Chung <jh80.chung@samsung.com> writes:
>
> > Hi
> >
> > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> >> Hi
> >>
> >> On 7/10/21 2:32 AM, Justin Forbes wrote:
> >>> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> >>> <jforbes@fedoraproject.org> wrote:
> >>>>
> >>>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> >>>> This works fine with the existing driver once it knows to claim it.
> >>>> Simple patch to add the device.
> >>>>
> >>>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> >
> > If this patch is merged, can this patch be also applied on stable tree?
>
> Luca, what should we do with this patch?
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


Is that to imply that there is an issue with the submission?  Happy to
fix any problems, but it would nice to get this in soon.  I know the
5.14 merge window was already opened when I sent it, but the 5.15 MR
is opening soon.  Hardware is definitely shipping and in users hands.

Justin
Coelho, Luciano Aug. 31, 2021, 6:36 a.m. UTC | #6
On Wed, 2021-08-25 at 13:07 -0500, Justin Forbes wrote:
> On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@codeaurora.org> wrote:
> > 
> > Jaehoon Chung <jh80.chung@samsung.com> writes:
> > 
> > > Hi
> > > 
> > > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> > > > Hi
> > > > 
> > > > On 7/10/21 2:32 AM, Justin Forbes wrote:
> > > > > On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> > > > > <jforbes@fedoraproject.org> wrote:
> > > > > > 
> > > > > > The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> > > > > > This works fine with the existing driver once it knows to claim it.
> > > > > > Simple patch to add the device.
> > > > > > 
> > > > > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> > > 
> > > If this patch is merged, can this patch be also applied on stable tree?
> > 
> > Luca, what should we do with this patch?
> > 
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> > 
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 
> 
> Is that to imply that there is an issue with the submission?  Happy to
> fix any problems, but it would nice to get this in soon.  I know the
> 5.14 merge window was already opened when I sent it, but the 5.15 MR
> is opening soon.  Hardware is definitely shipping and in users hands.

Sorry for the delay here.  This fell between the cracks.

Kalle can you apply this directly to your tree? I'll assign it to you.
And, if possible, add the cc-stable tag so it gets picked up. :)

Longer reasoning: generally we detect the hardware in a more
programmatic way, by checking the type from registers (and not relying
entirely on the PCI IDs), but for some reason this type of device is
still using the legacy way of matching the exact PCI ID to a device
type.  Thus, this patch is needed, at least for now.

Thanks!

--
Cheers,
Luca.
Kalle Valo Aug. 31, 2021, 6:49 a.m. UTC | #7
"Coelho, Luciano" <luciano.coelho@intel.com> writes:

> On Wed, 2021-08-25 at 13:07 -0500, Justin Forbes wrote:
>> On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>> > 
>> > Jaehoon Chung <jh80.chung@samsung.com> writes:
>> > 
>> > > Hi
>> > > 
>> > > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
>> > > > Hi
>> > > > 
>> > > > On 7/10/21 2:32 AM, Justin Forbes wrote:
>> > > > > On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
>> > > > > <jforbes@fedoraproject.org> wrote:
>> > > > > > 
>> > > > > > The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>> > > > > > This works fine with the existing driver once it knows to claim it.
>> > > > > > Simple patch to add the device.
>> > > > > > 
>> > > > > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
>> > > 
>> > > If this patch is merged, can this patch be also applied on stable tree?
>> > 
>> > Luca, what should we do with this patch?
>> > 
>> > --
>> > https://patchwork.kernel.org/project/linux-wireless/list/
>> > 
>> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>> 
>> 
>> Is that to imply that there is an issue with the submission?  Happy to
>> fix any problems, but it would nice to get this in soon.  I know the
>> 5.14 merge window was already opened when I sent it, but the 5.15 MR
>> is opening soon.  Hardware is definitely shipping and in users hands.
>
> Sorry for the delay here.  This fell between the cracks.
>
> Kalle can you apply this directly to your tree? I'll assign it to you.

Ok, I'll queue this to v5.15.

> And, if possible, add the cc-stable tag so it gets picked up. :)

Ok.
Kalle Valo Sept. 2, 2021, 4:39 p.m. UTC | #8
"Justin M. Forbes" <jforbes@fedoraproject.org> wrote:

> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> This works fine with the existing driver once it knows to claim it.
> Simple patch to add the device.
> 
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Patch applied to wireless-drivers.git, thanks.

2f32c147a381 iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 16baee3d52ae..63f5598ebe3f 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -558,6 +558,7 @@  static const struct iwl_dev_info iwl_dev_info_table[] = {
 	IWL_DEV_INFO(0xA0F0, 0x1652, killer1650i_2ax_cfg_qu_b0_hr_b0, NULL),
 	IWL_DEV_INFO(0xA0F0, 0x2074, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0xA0F0, 0x4070, iwl_ax201_cfg_qu_hr, NULL),
+	IWL_DEV_INFO(0xA0F0, 0x6074, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0x02F0, 0x0070, iwl_ax201_cfg_quz_hr, NULL),
 	IWL_DEV_INFO(0x02F0, 0x0074, iwl_ax201_cfg_quz_hr, NULL),
 	IWL_DEV_INFO(0x02F0, 0x6074, iwl_ax201_cfg_quz_hr, NULL),