diff mbox series

mac80211: include <linux/rbtree.h>

Message ID 20210715180234.512d64dee655.Ia51c29a9fb1e651e06bc00eabec90974103d333e@changeid (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series mac80211: include <linux/rbtree.h> | expand

Commit Message

Johannes Berg July 15, 2021, 4:02 p.m. UTC 
From: Johannes Berg <johannes.berg@intel.com>

This is needed for the rbtree, and we shouldn't just rely
on it getting included somewhere implicitly. Include it
explicitly.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/mac80211/ieee80211_i.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Toke Høiland-Jørgensen July 19, 2021, 12:31 p.m. UTC | #1 
Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> This is needed for the rbtree, and we shouldn't just rely
> on it getting included somewhere implicitly. Include it
> explicitly.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Does this need a Fixes: tag?

Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Johannes Berg July 19, 2021, 12:34 p.m. UTC | #2 
On Mon, 2021-07-19 at 14:31 +0200, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > This is needed for the rbtree, and we shouldn't just rely
> > on it getting included somewhere implicitly. Include it
> > explicitly.
> > 
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> Does this need a Fixes: tag?

We seem to always get it implicitly in the current kernel, so I guess
not really necessary to backport or anything, I'd say no.

I just ran into it while preparing a new backports import to our
internal tree.

johannes
Toke Høiland-Jørgensen July 19, 2021, 12:39 p.m. UTC | #3 
Johannes Berg <johannes@sipsolutions.net> writes:

> On Mon, 2021-07-19 at 14:31 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>> 
>> > From: Johannes Berg <johannes.berg@intel.com>
>> > 
>> > This is needed for the rbtree, and we shouldn't just rely
>> > on it getting included somewhere implicitly. Include it
>> > explicitly.
>> > 
>> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> 
>> Does this need a Fixes: tag?
>
> We seem to always get it implicitly in the current kernel, so I guess
> not really necessary to backport or anything, I'd say no.
>
> I just ran into it while preparing a new backports import to our
> internal tree.

Alright, fair enough :)

-Toke
diff mbox series

Patch

diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 22549b95d1aa..1c14cecf9813 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -25,6 +25,7 @@ 
 #include <linux/leds.h>
 #include <linux/idr.h>
 #include <linux/rhashtable.h>
+#include <linux/rbtree.h>
 #include <net/ieee80211_radiotap.h>
 #include <net/cfg80211.h>
 #include <net/mac80211.h>