| Message ID | 20210831081849.GB9846@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b6a46b4f6e4b35868e33930acaa7c50bf6cab821 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] iwlwifi: mvm: d3: Fix off by ones in iwl_mvm_wowlan_get_rsc_v5_data() | expand |
On Tue, 2021-08-31 at 11:18 +0300, Dan Carpenter wrote: > This code was refactored and the mutex_unlock(&mvm->mutex); was > accidentally deleted. > > Fixes: af3aab9ce298 ("iwlwifi: mvm: d3: make key reprogramming iteration optional") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c > index 6e3a63a5a75c..9f706fffb592 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c > @@ -160,6 +160,7 @@ static void iwl_mvm_wowlan_program_keys(struct ieee80211_hw *hw, > mvm->ptk_icvlen = key->icv_len; > mvm->gtk_ivlen = key->iv_len; > mvm->gtk_icvlen = key->icv_len; > + mutex_unlock(&mvm->mutex); > > > /* don't upload key again */ > return; Thank you, Dan! Acked-by: Luca Coelho <luca@coelho.fi> -- Cheers, Luca.
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c index 6e3a63a5a75c..9f706fffb592 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c @@ -160,6 +160,7 @@ static void iwl_mvm_wowlan_program_keys(struct ieee80211_hw *hw, mvm->ptk_icvlen = key->icv_len; mvm->gtk_ivlen = key->iv_len; mvm->gtk_icvlen = key->icv_len; + mutex_unlock(&mvm->mutex); /* don't upload key again */ return;
This code was refactored and the mutex_unlock(&mvm->mutex); was accidentally deleted. Fixes: af3aab9ce298 ("iwlwifi: mvm: d3: make key reprogramming iteration optional") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 1 + 1 file changed, 1 insertion(+)