| Message ID | 20210916153621.16576-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | nfc: trf7970a: Make use of the helper function dev_err_probe() | expand |
On 16/09/2021 17:36, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/nfc/trf7970a.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Please don't send patches one-by-one, but group them in series. Same response - I think the preferred approach was Rob's dev_err removal. P.S. You need to Cc all folks and all lists. The cc-list here is too short. Best regards, Krzysztof
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index 8890fcd59c39..8459a2735f2c 100644 --- a/drivers/nfc/trf7970a.c +++ b/drivers/nfc/trf7970a.c @@ -2067,8 +2067,8 @@ static int trf7970a_probe(struct spi_device *spi) trf->regulator = devm_regulator_get(&spi->dev, "vin"); if (IS_ERR(trf->regulator)) { - ret = PTR_ERR(trf->regulator); - dev_err(trf->dev, "Can't get VIN regulator: %d\n", ret); + ret = dev_err_probe(trf->dev, PTR_ERR(trf->regulator), + "Can't get VIN regulator\n"); goto err_destroy_lock; } @@ -2084,8 +2084,8 @@ static int trf7970a_probe(struct spi_device *spi) trf->regulator = devm_regulator_get(&spi->dev, "vdd-io"); if (IS_ERR(trf->regulator)) { - ret = PTR_ERR(trf->regulator); - dev_err(trf->dev, "Can't get VDD_IO regulator: %d\n", ret); + ret = dev_err_probe(trf->dev, PTR_ERR(trf->regulator), + "Can't get VDD_IO regulator\n"); goto err_destroy_lock; }
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/nfc/trf7970a.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)