| Message ID | 20211018235021.1279697-10-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d8a416def4c8139e07e9e126359e781268d04a2d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wireless: don't write to netdev->dev_addr directly | expand |
On Tue, 19 Oct 2021 at 03:50, Jakub Kicinski <kuba@kernel.org> wrote: > > netdev->dev_addr will be come const soon, constify the argument > to command send to avoid compiler warnings. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: stas.yakovlev@gmail.com > CC: kvalo@codeaurora.org > CC: linux-wireless@vger.kernel.org > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 6 +++--- > drivers/net/wireless/intel/ipw2x00/ipw2200.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > Looks fine, thanks! Stanislav.
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 0a38d17744a9..23037bfc9e4c 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -199,7 +199,7 @@ static int ipw_queue_tx_reclaim(struct ipw_priv *priv, struct clx2_tx_queue *txq, int qindex); static int ipw_queue_reset(struct ipw_priv *priv); -static int ipw_queue_tx_hcmd(struct ipw_priv *priv, int hcmd, void *buf, +static int ipw_queue_tx_hcmd(struct ipw_priv *priv, int hcmd, const void *buf, int len, int sync); static void ipw_tx_queue_free(struct ipw_priv *); @@ -2264,7 +2264,7 @@ static int ipw_send_cmd_simple(struct ipw_priv *priv, u8 command) } static int ipw_send_cmd_pdu(struct ipw_priv *priv, u8 command, u8 len, - void *data) + const void *data) { struct host_cmd cmd = { .cmd = command, @@ -5033,7 +5033,7 @@ static int ipw_queue_tx_reclaim(struct ipw_priv *priv, return used; } -static int ipw_queue_tx_hcmd(struct ipw_priv *priv, int hcmd, void *buf, +static int ipw_queue_tx_hcmd(struct ipw_priv *priv, int hcmd, const void *buf, int len, int sync) { struct clx2_tx_queue *txq = &priv->txq_cmd; diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.h b/drivers/net/wireless/intel/ipw2x00/ipw2200.h index 98fe62737888..55cac934f4ee 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.h +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.h @@ -1945,7 +1945,7 @@ struct host_cmd { u8 cmd; u8 len; u16 reserved; - u32 *param; + const u32 *param; } __packed; /* XXX */ struct cmdlog_host_cmd {
netdev->dev_addr will be come const soon, constify the argument to command send to avoid compiler warnings. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: stas.yakovlev@gmail.com CC: kvalo@codeaurora.org CC: linux-wireless@vger.kernel.org --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 6 +++--- drivers/net/wireless/intel/ipw2x00/ipw2200.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)