| Message ID | 20220107030419.2380198-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | dt-bindings: net: wireless: mt76: Fix 8-bit property sizes | expand |
On Thu, 06 Jan 2022 21:04:17 -0600, Rob Herring wrote: > The '/bits/ 8' notation applies the next <> list of values. Another <> list > is encoded as 32-bits by default. IOW, each <> list needs to be preceeded > with '/bits/ 8'. > > While the dts format allows this, as a rule we don't mix sizes for DT > properties since all size information is lost in the dtb file. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml index 1489d3c1cd6e..269cd63fb544 100644 --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml @@ -191,9 +191,9 @@ examples: channels = <36 48>; rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>; rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>, - <3 22 22 22 22 22 22 22 22 22 22>; + /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>; rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>, - <4 20 20 20 20 20 20 20 20 20 20 20 20>; + /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>; }; b1 { channels = <100 181>;
The '/bits/ 8' notation applies the next <> list of values. Another <> list is encoded as 32-bits by default. IOW, each <> list needs to be preceeded with '/bits/ 8'. While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file. Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)