diff mbox series

ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk()

Message ID 20220111071445.GA11243@kili (mailing list archive)
State Accepted
Commit c9b41832dc080fa59bad597de94865b3ea2d5bab
Delegated to: Kalle Valo
Headers show
Series ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk() | expand

Commit Message

Dan Carpenter Jan. 11, 2022, 7:14 a.m. UTC 
The "ret" vairable is not set at this point.  It could be uninitialized
or zero.  The correct thing to return is -ENODEV.

Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Jan. 17, 2022, 12:37 p.m. UTC | #1 
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The "ret" vairable is not set at this point.  It could be uninitialized
> or zero.  The correct thing to return is -ENODEV.
> 
> Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

c9b41832dc08 ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk()
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index 65d3c6ba35ae..cf9f4ba75e03 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1932,7 +1932,7 @@  static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab)
 			if (!hremote_node) {
 				ath11k_dbg(ab, ATH11K_DBG_QMI,
 					   "qmi fail to get hremote_node\n");
-				return ret;
+				return -ENODEV;
 			}
 
 			ret = of_address_to_resource(hremote_node, 0, &res);