diff mbox series

[next] brcmfmac: of: remove redundant variable len

Message ID 20220207133329.336664-1-colin.i.king@gmail.com (mailing list archive)
State Accepted
Commit 2fd6d2ef68607b9da952796c7aab352791daec66
Delegated to: Kalle Valo
Headers show
Series [next] brcmfmac: of: remove redundant variable len | expand

Commit Message

Colin Ian King Feb. 7, 2022, 1:33 p.m. UTC
The variable len is being assigned bit is never used. The variable
and the strlen call are redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Kalle Valo Feb. 10, 2022, 8:47 a.m. UTC | #1
Colin Ian King <colin.i.king@gmail.com> wrote:

> The variable len is being assigned bit is never used. The variable
> and the strlen call are redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Patch applied to wireless-next.git, thanks.

2fd6d2ef6860 brcmfmac: of: remove redundant variable len
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 5708de1d9f26..8623bde5eb70 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -71,14 +71,13 @@  void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 	/* Set board-type to the first string of the machine compatible prop */
 	root = of_find_node_by_path("/");
 	if (root) {
-		int i, len;
+		int i;
 		char *board_type;
 		const char *tmp;
 
 		of_property_read_string_index(root, "compatible", 0, &tmp);
 
 		/* get rid of '/' in the compatible string to be able to find the FW */
-		len = strlen(tmp) + 1;
 		board_type = devm_kstrdup(dev, tmp, GFP_KERNEL);
 		if (!board_type) {
 			of_node_put(root);