diff mbox series

ath11k: fix uninitialized rate_idx in ath11k_dp_tx_update_txcompl()

Message ID 20220209060816.423-1-quic_wgong@quicinc.com (mailing list archive)
State Accepted
Commit 8c4c567fa291e4805d5116f1333b2ed83877032b
Delegated to: Kalle Valo
Headers show
Series ath11k: fix uninitialized rate_idx in ath11k_dp_tx_update_txcompl() | expand

Commit Message

Wen Gong Feb. 9, 2022, 6:08 a.m. UTC
The rate_idx which passed to ath11k_debugfs_sta_add_tx_stats() by
ath11k_dp_tx_update_txcompl() is not initialized, add initialization
for it.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2

Fixes: 1b8bb94c0612 ("ath11k: report tx bitrate for iw wlan station dump")
Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/dp_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 76680d49b5e0e661bc4abcdaf13fb7e124b4ca08

Comments

Kalle Valo Feb. 14, 2022, 5:45 p.m. UTC | #1
Wen Gong <quic_wgong@quicinc.com> wrote:

> The rate_idx which passed to ath11k_debugfs_sta_add_tx_stats() by
> ath11k_dp_tx_update_txcompl() is not initialized, add initialization
> for it.
> 
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2
> 
> Fixes: 1b8bb94c0612 ("ath11k: report tx bitrate for iw wlan station dump")
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

8c4c567fa291 ath11k: fix uninitialized rate_idx in ath11k_dp_tx_update_txcompl()
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
index 91d6244b6543..8402961c6688 100644
--- a/drivers/net/wireless/ath/ath11k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
@@ -426,7 +426,7 @@  void ath11k_dp_tx_update_txcompl(struct ath11k *ar, struct hal_tx_status *ts)
 	struct ath11k_sta *arsta;
 	struct ieee80211_sta *sta;
 	u16 rate, ru_tones;
-	u8 mcs, rate_idx, ofdma;
+	u8 mcs, rate_idx = 0, ofdma;
 	int ret;
 
 	spin_lock_bh(&ab->base_lock);