| Message ID | 20220506075814.115059-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 84dc992e23df2633c7bd4f662e3f0073c126aac7 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ssb: remove unreachable code | expand |
On Fri, 6 May 2022 15:58:14 +0800 Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > Clean up the following smatch warning: > > drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable > code. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/ssb/pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c > index 148bcb99c212..493bebbba521 100644 > --- a/drivers/ssb/pci.c > +++ b/drivers/ssb/pci.c > @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus, > err = 0; > goto out_free; > } > - pr_warn("WARNING: Invalid SPROM CRC (corrupt > SPROM)\n"); } > } > err = sprom_extract(bus, sprom, buf, bus->sprom_size); Acked-by: Michael Büsch <m@bues.ch>
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > Clean up the following smatch warning: > > drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable > code. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Acked-by: Michael Büsch <m@bues.ch> Patch applied to wireless-next.git, thanks. 84dc992e23df ssb: remove unreachable code
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c index 148bcb99c212..493bebbba521 100644 --- a/drivers/ssb/pci.c +++ b/drivers/ssb/pci.c @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus, err = 0; goto out_free; } - pr_warn("WARNING: Invalid SPROM CRC (corrupt SPROM)\n"); } } err = sprom_extract(bus, sprom, buf, bus->sprom_size);
Clean up the following smatch warning: drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable code. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/ssb/pci.c | 1 - 1 file changed, 1 deletion(-)