diff mbox series

[v2] net: rtlwifi: Use pr_warn instead of WARN_ONCE

Message ID 20220511014453.1621366-1-dzm91@hust.edu.cn (mailing list archive)
State Accepted
Commit ad732da434a2936128769216eddaece3b1af4588
Delegated to: Kalle Valo
Headers show
Series [v2] net: rtlwifi: Use pr_warn instead of WARN_ONCE | expand

Commit Message

Dongliang Mu May 11, 2022, 1:44 a.m. UTC 
From: Dongliang Mu <mudongliangabcd@gmail.com>

This memory allocation failure can be triggered by fault injection or
high pressure testing, resulting a WARN.

Fix this by replacing WARN with pr_warn.

Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
v1->v2: change to pr_warn as suggested by Kalle Valo
 drivers/net/wireless/realtek/rtlwifi/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo May 13, 2022, 6:20 a.m. UTC | #1 
Dongliang Mu <dzm91@hust.edu.cn> wrote:

> From: Dongliang Mu <mudongliangabcd@gmail.com>
> 
> This memory allocation failure can be triggered by fault injection or
> high pressure testing, resulting a WARN.
> 
> Fix this by replacing WARN with pr_warn.
> 
> Reported-by: syzkaller <syzkaller@googlegroups.com>
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>

Patch applied to wireless-next.git, thanks.

ad732da434a2 rtlwifi: Use pr_warn instead of WARN_ONCE
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 86a236873254..a8eebafb9a7e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -1014,7 +1014,7 @@  int rtl_usb_probe(struct usb_interface *intf,
 	hw = ieee80211_alloc_hw(sizeof(struct rtl_priv) +
 				sizeof(struct rtl_usb_priv), &rtl_ops);
 	if (!hw) {
-		WARN_ONCE(true, "rtl_usb: ieee80211 alloc failed\n");
+		pr_warn("rtl_usb: ieee80211 alloc failed\n");
 		return -ENOMEM;
 	}
 	rtlpriv = hw->priv;