| Message ID | 20220523140812.164028-1-ajay.kathat@microchip.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2,1/4] wilc1000: use correct sequence of RESET for chip Power-UP/Down | expand |
Hi, Ajay, On 23.05.2022 17:09, Ajay Kathat - I15481 wrote: > From: Ajay Singh <ajay.kathat@microchip.com> > > For power-up sequence, WILC expects RESET set to high 5ms after making > chip_en(enable) so corrected chip power-up sequence by making RESET high. > For Power-Down sequence, the correct sequence make RESET and CHIP_EN low > without any extra delay. > > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> Does this need a fixes tag? > --- > drivers/net/wireless/microchip/wilc1000/spi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c > index 18420e954402..2ae8dd3411ac 100644 > --- a/drivers/net/wireless/microchip/wilc1000/spi.c > +++ b/drivers/net/wireless/microchip/wilc1000/spi.c > @@ -191,11 +191,11 @@ static void wilc_wlan_power(struct wilc *wilc, bool on) > /* assert ENABLE: */ > gpiod_set_value(gpios->enable, 1); > mdelay(5); > - /* deassert RESET: */ > - gpiod_set_value(gpios->reset, 0); > - } else { > /* assert RESET: */ > gpiod_set_value(gpios->reset, 1); > + } else { > + /* deassert RESET: */ > + gpiod_set_value(gpios->reset, 0); > /* deassert ENABLE: */ > gpiod_set_value(gpios->enable, 0); > }
On 24/05/22 13:39, Claudiu Beznea - M18063 wrote: > Hi, Ajay, > > On 23.05.2022 17:09, Ajay Kathat - I15481 wrote: >> From: Ajay Singh <ajay.kathat@microchip.com> >> >> For power-up sequence, WILC expects RESET set to high 5ms after making >> chip_en(enable) so corrected chip power-up sequence by making RESET high. >> For Power-Down sequence, the correct sequence make RESET and CHIP_EN low >> without any extra delay. >> >> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> > Does this need a fixes tag? Yes, I will add the Fixes tag and send the v3 series. Regards, Ajay
diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c index 18420e954402..2ae8dd3411ac 100644 --- a/drivers/net/wireless/microchip/wilc1000/spi.c +++ b/drivers/net/wireless/microchip/wilc1000/spi.c @@ -191,11 +191,11 @@ static void wilc_wlan_power(struct wilc *wilc, bool on) /* assert ENABLE: */ gpiod_set_value(gpios->enable, 1); mdelay(5); - /* deassert RESET: */ - gpiod_set_value(gpios->reset, 0); - } else { /* assert RESET: */ gpiod_set_value(gpios->reset, 1); + } else { + /* deassert RESET: */ + gpiod_set_value(gpios->reset, 0); /* deassert ENABLE: */ gpiod_set_value(gpios->enable, 0); }