diff mbox series

[34/50] wifi: ath12k: add mhi.h

Message ID 20220812161003.27279-35-kvalo@kernel.org (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show
Series wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices | expand

Commit Message

Kalle Valo Aug. 12, 2022, 4:09 p.m. UTC 
From: Kalle Valo <quic_kvalo@quicinc.com>

(Patches split into one patch per file for easier review, but the final
commit will be one big patch. See the cover letter for more info.)

Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/mhi.h | 46 +++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

Comments

Jeff Johnson Aug. 18, 2022, 10:30 p.m. UTC | #1 
On 8/12/2022 9:09 AM, Kalle Valo wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
> 
> (Patches split into one patch per file for easier review, but the final
> commit will be one big patch. See the cover letter for more info.)
> 
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
>   drivers/net/wireless/ath/ath12k/mhi.h | 46 +++++++++++++++++++++++++++++++++++
>   1 file changed, 46 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/mhi.h b/drivers/net/wireless/ath/ath12k/mhi.h
> new file mode 100644
> index 000000000000..258152d3a7dd
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath12k/mhi.h
> @@ -0,0 +1,46 @@
> +/* SPDX-License-Identifier: BSD-3-Clause-Clear */
> +/*
> + * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
> + * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +#ifndef _ATH12K_MHI_H
> +#define _ATH12K_MHI_H
> +
> +#include "pci.h"
> +
> +#define PCIE_TXVECDB				0x360
> +#define PCIE_TXVECSTATUS			0x368
> +#define PCIE_RXVECDB				0x394
> +#define PCIE_RXVECSTATUS			0x39C
> +
> +#define MHISTATUS				0x48
> +#define MHICTRL					0x38
> +#define MHICTRL_RESET_MASK			0x2
> +
> +enum ath12k_mhi_state {
> +	ATH12K_MHI_INIT,
> +	ATH12K_MHI_DEINIT,
> +	ATH12K_MHI_POWER_ON,
> +	ATH12K_MHI_POWER_OFF,
> +	ATH12K_MHI_FORCE_POWER_OFF,
> +	ATH12K_MHI_SUSPEND,
> +	ATH12K_MHI_RESUME,
> +	ATH12K_MHI_TRIGGER_RDDM,
> +	ATH12K_MHI_RDDM,
> +	ATH12K_MHI_RDDM_DONE,
> +};
> +
> +extern struct mhi_controller_config ath12k_mhi_config_qcn9274;
> +extern struct mhi_controller_config ath12k_mhi_config_wcn7850;

imo both should be const

> +
> +int ath12k_mhi_start(struct ath12k_pci *ar_pci);
> +void ath12k_mhi_stop(struct ath12k_pci *ar_pci);
> +int ath12k_mhi_register(struct ath12k_pci *ar_pci);
> +void ath12k_mhi_unregister(struct ath12k_pci *ar_pci);
> +void ath12k_mhi_set_mhictrl_reset(struct ath12k_base *ab);
> +void ath12k_mhi_clear_vector(struct ath12k_base *ab);
> +
> +void ath12k_mhi_suspend(struct ath12k_pci *ar_pci);
> +void ath12k_mhi_resume(struct ath12k_pci *ar_pci);
> +
> +#endif
>
Kalle Valo Nov. 8, 2022, 2:01 p.m. UTC | #2 
Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/12/2022 9:09 AM, Kalle Valo wrote:
>
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> (Patches split into one patch per file for easier review, but the final
>> commit will be one big patch. See the cover letter for more info.)
>>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

[...]

>> +extern struct mhi_controller_config ath12k_mhi_config_qcn9274;
>> +extern struct mhi_controller_config ath12k_mhi_config_wcn7850;
>
> imo both should be const

Fixed.
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath12k/mhi.h b/drivers/net/wireless/ath/ath12k/mhi.h
new file mode 100644
index 000000000000..258152d3a7dd
--- /dev/null
+++ b/drivers/net/wireless/ath/ath12k/mhi.h
@@ -0,0 +1,46 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause-Clear */
+/*
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+#ifndef _ATH12K_MHI_H
+#define _ATH12K_MHI_H
+
+#include "pci.h"
+
+#define PCIE_TXVECDB				0x360
+#define PCIE_TXVECSTATUS			0x368
+#define PCIE_RXVECDB				0x394
+#define PCIE_RXVECSTATUS			0x39C
+
+#define MHISTATUS				0x48
+#define MHICTRL					0x38
+#define MHICTRL_RESET_MASK			0x2
+
+enum ath12k_mhi_state {
+	ATH12K_MHI_INIT,
+	ATH12K_MHI_DEINIT,
+	ATH12K_MHI_POWER_ON,
+	ATH12K_MHI_POWER_OFF,
+	ATH12K_MHI_FORCE_POWER_OFF,
+	ATH12K_MHI_SUSPEND,
+	ATH12K_MHI_RESUME,
+	ATH12K_MHI_TRIGGER_RDDM,
+	ATH12K_MHI_RDDM,
+	ATH12K_MHI_RDDM_DONE,
+};
+
+extern struct mhi_controller_config ath12k_mhi_config_qcn9274;
+extern struct mhi_controller_config ath12k_mhi_config_wcn7850;
+
+int ath12k_mhi_start(struct ath12k_pci *ar_pci);
+void ath12k_mhi_stop(struct ath12k_pci *ar_pci);
+int ath12k_mhi_register(struct ath12k_pci *ar_pci);
+void ath12k_mhi_unregister(struct ath12k_pci *ar_pci);
+void ath12k_mhi_set_mhictrl_reset(struct ath12k_base *ab);
+void ath12k_mhi_clear_vector(struct ath12k_base *ab);
+
+void ath12k_mhi_suspend(struct ath12k_pci *ar_pci);
+void ath12k_mhi_resume(struct ath12k_pci *ar_pci);
+
+#endif