| Message ID | 20220916063047.155021-1-chi.minghao@zte.com.cn (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | carl9170: use strscpy() is more robust and safer | expand |
cgel.zte@gmail.com writes: > From: Minghao Chi <chi.minghao@zte.com.cn> > > The implementation of strscpy() is more robust and safer. > > That's now the recommended way to copy NUL terminated strings. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > drivers/net/wireless/ath/carl9170/fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/carl9170/fw.c b/drivers/net/wireless/ath/carl9170/fw.c > index 1ab09e1c9ec5..4c1aecd1163c 100644 > --- a/drivers/net/wireless/ath/carl9170/fw.c > +++ b/drivers/net/wireless/ath/carl9170/fw.c > @@ -105,7 +105,7 @@ static void carl9170_fw_info(struct ar9170 *ar) > CARL9170FW_GET_MONTH(fw_date), > CARL9170FW_GET_DAY(fw_date)); > > - strlcpy(ar->hw->wiphy->fw_version, motd_desc->release, > + strscpy(ar->hw->wiphy->fw_version, motd_desc->release, > sizeof(ar->hw->wiphy->fw_version)); Already changed in: https://git.kernel.org/netdev/net-next/c/bf99f11df4de Please use latest trees to avoid duplicate work.
diff --git a/drivers/net/wireless/ath/carl9170/fw.c b/drivers/net/wireless/ath/carl9170/fw.c index 1ab09e1c9ec5..4c1aecd1163c 100644 --- a/drivers/net/wireless/ath/carl9170/fw.c +++ b/drivers/net/wireless/ath/carl9170/fw.c @@ -105,7 +105,7 @@ static void carl9170_fw_info(struct ar9170 *ar) CARL9170FW_GET_MONTH(fw_date), CARL9170FW_GET_DAY(fw_date)); - strlcpy(ar->hw->wiphy->fw_version, motd_desc->release, + strscpy(ar->hw->wiphy->fw_version, motd_desc->release, sizeof(ar->hw->wiphy->fw_version)); } }