Message ID | 20221013100522.46346-1-johannes@sipsolutions.net (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Kalle Valo |
Headers | show |
Series | pull-request: wireless-2022-10-13 | expand |
On Thu, 13 Oct 2022 12:04:51 +0200 Johannes Berg wrote: > So as discussed previously, here are the fixes for the > scan parsing issues. I had to create a merge commit to > keep the stable commit IDs that we'd already used for > communication. > > Please pull and let me know if there's any problem. Odd, bot doesn't want to reply. Paolo pulled this a few hours ago FWIW.
On Thu, 13 Oct 2022 12:04:51 +0200 Johannes Berg wrote:
> Please pull and let me know if there's any problem.
Since you asked if there are any problems... :)
net/wireless/scan.c:1677:61: warning: incorrect type in argument 2 (different address spaces)
net/wireless/scan.c:1677:61: expected struct cfg80211_bss_ies const *new_ies
net/wireless/scan.c:1677:61: got struct cfg80211_bss_ies const [noderef] __rcu *beacon_ies
On Thu, 2022-10-13 at 08:32 -0700, Jakub Kicinski wrote: > On Thu, 13 Oct 2022 12:04:51 +0200 Johannes Berg wrote: > > Please pull and let me know if there's any problem. > > Since you asked if there are any problems... :) > > net/wireless/scan.c:1677:61: warning: incorrect type in argument 2 (different address spaces) > net/wireless/scan.c:1677:61: expected struct cfg80211_bss_ies const *new_ies > net/wireless/scan.c:1677:61: got struct cfg80211_bss_ies const [noderef] __rcu *beacon_ies > Oh shoot, I had noticed this later and forgot about it ... FWIW, it's harmless, but we do need to silence the sparse warning. I'll add a follow-up patch for our next pull request, unless you want it quickly, then I can send it to you directly? johannes
On Thu, 13 Oct 2022 18:13:00 +0200 Johannes Berg wrote: > FWIW, it's harmless, but we do need to silence the sparse warning. I'll > add a follow-up patch for our next pull request, unless you want it > quickly, then I can send it to you directly? Next PR is perfectly fine, I reckon.