diff mbox series

[01/10] wifi: mt76: extend aggr_stats for tri-band support

Message ID 20221031164000.17063-2-shayne.chen@mediatek.com (mailing list archive)
State Superseded
Delegated to: Felix Fietkau
Headers show
Series Add driver for MediaTek Wi-Fi 7 devices | expand

Commit Message

Shayne Chen Oct. 31, 2022, 4:39 p.m. UTC 
Make band2 able to report aggregation stats.
This is a preliminary patch to add mt7996 chipset support.

Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt76.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lorenzo Bianconi Nov. 2, 2022, 10:37 p.m. UTC | #1 
On Nov 01, Shayne Chen wrote:
> Make band2 able to report aggregation stats.
> This is a preliminary patch to add mt7996 chipset support.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
> index f9bdf16fc6c4..42847b327cb0 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> @@ -781,7 +781,7 @@ struct mt76_dev {
>  
>  	u32 rev;
>  
> -	u32 aggr_stats[32];
> +	u32 aggr_stats[16 * __MT_MAX_BAND];

I think this patch will break mt7915 and mt7921 drivers.

Regards,
Lorenzo

>  
>  	struct tasklet_struct pre_tbtt_tasklet;
>  	int beacon_int;
> -- 
> 2.25.1
>
Shayne Chen Nov. 7, 2022, 7 a.m. UTC | #2 
On Wed, 2022-11-02 at 23:37 +0100, Lorenzo Bianconi wrote:
> On Nov 01, Shayne Chen wrote:
> > Make band2 able to report aggregation stats.
> > This is a preliminary patch to add mt7996 chipset support.
> > 
> > Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> > ---
> >  drivers/net/wireless/mediatek/mt76/mt76.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h
> > b/drivers/net/wireless/mediatek/mt76/mt76.h
> > index f9bdf16fc6c4..42847b327cb0 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> > @@ -781,7 +781,7 @@ struct mt76_dev {
> >  
> >  	u32 rev;
> >  
> > -	u32 aggr_stats[32];
> > +	u32 aggr_stats[16 * __MT_MAX_BAND];
> 
> I think this patch will break mt7915 and mt7921 drivers.
> 
> Regards,
> Lorenzo
> 
Hi Lore,

Will rebase on top of your fix in v2.

Thanks,
Shayne
> >  
> >  	struct tasklet_struct pre_tbtt_tasklet;
> >  	int beacon_int;
> > -- 
> > 2.25.1
> >
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
index f9bdf16fc6c4..42847b327cb0 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76.h
@@ -781,7 +781,7 @@  struct mt76_dev {
 
 	u32 rev;
 
-	u32 aggr_stats[32];
+	u32 aggr_stats[16 * __MT_MAX_BAND];
 
 	struct tasklet_struct pre_tbtt_tasklet;
 	int beacon_int;