| Message ID | 20230102081142.3937570-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ed3f83b3459a67a3ab9d806490ac304b567b1c2d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup | expand |
On Mon, Jan 02, 2023 at 12:11:42PM +0400, Miaoqian Lin wrote: > crypto_alloc_shash() allocates resources, which should be released by > crypto_free_shash(). When ath11k_peer_find() fails, there has memory > leak. Add missing crypto_free_shash() to fix this. > > Fixes: 243874c64c81 ("ath11k: handle RX fragments") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > change in v2: > - add crypto_free_shash() in the error path instead of move > crypto_alloc_shash(). > --- > drivers/net/wireless/ath/ath11k/dp_rx.c | 1 + > 1 file changed, 1 insertion(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Miaoqian Lin <linmq006@gmail.com> wrote: > crypto_alloc_shash() allocates resources, which should be released by > crypto_free_shash(). When ath11k_peer_find() fails, there has memory > leak. Add missing crypto_free_shash() to fix this. > > Fixes: 243874c64c81 ("ath11k: handle RX fragments") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. ed3f83b3459a wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index c5a4c34d7749..0c53d88293eb 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -3126,6 +3126,7 @@ int ath11k_peer_rx_frag_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id if (!peer) { ath11k_warn(ab, "failed to find the peer to set up fragment info\n"); spin_unlock_bh(&ab->base_lock); + crypto_free_shash(tfm); return -ENOENT; }
crypto_alloc_shash() allocates resources, which should be released by crypto_free_shash(). When ath11k_peer_find() fails, there has memory leak. Add missing crypto_free_shash() to fix this. Fixes: 243874c64c81 ("ath11k: handle RX fragments") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- change in v2: - add crypto_free_shash() in the error path instead of move crypto_alloc_shash(). --- drivers/net/wireless/ath/ath11k/dp_rx.c | 1 + 1 file changed, 1 insertion(+)