| Message ID | 20230212145238.123055-2-pchelkin@ispras.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Toke Høiland-Jørgensen |
| Headers | show |
| Series | wifi: ath9k: hif_usb: fix memory leak of remain_skbs | expand |
Fedor Pchelkin <pchelkin@ispras.ru> writes: > hif_dev->remain_skb is allocated and used exclusively in > ath9k_hif_usb_rx_stream(). It is implied that an allocated remain_skb is > processed and subsequently freed (in error paths) only during the next > call of ath9k_hif_usb_rx_stream(). > > So, if the device is deinitialized between those two calls or if the skb > contents are incorrect, it is possible that ath9k_hif_usb_rx_stream() is > not called next time and the allocated remain_skb is leaked. Our local > Syzkaller instance was able to trigger that. > > Fix the leak by introducing a function to explicitly free remain_skb (if > it is not NULL) when the device is being deinitialized. remain_skb is NULL > when it has not been allocated at all (hif_dev struct is kzalloced) or > when it has been proccesed in next call to ath9k_hif_usb_rx_stream(). > > Proper spinlocks are held to prevent possible concurrent access to > remain_skb from the interrupt context ath9k_hif_usb_rx_stream(). These > accesses should not happen as rx_urbs have been deallocated before but > it prevents a dangerous race condition in these cases. > > Found by Linux Verification Center (linuxtesting.org) with Syzkaller. > > Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.") > Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > --- > drivers/net/wireless/ath/ath9k/hif_usb.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c > index f521dfa2f194..e03ab972edf7 100644 > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c > @@ -534,6 +534,23 @@ static struct ath9k_htc_hif hif_usb = { > .send = hif_usb_send, > }; > > +/* Need to free remain_skb allocated in ath9k_hif_usb_rx_stream > + * in case ath9k_hif_usb_rx_stream wasn't called next time to > + * process the buffer and subsequently free it. > + */ > +static void ath9k_hif_usb_free_rx_remain_skb(struct hif_device_usb *hif_dev) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&hif_dev->rx_lock, flags); > + if (hif_dev->remain_skb) { > + dev_kfree_skb_any(hif_dev->remain_skb); > + hif_dev->remain_skb = NULL; > + hif_dev->rx_remain_len = 0; > + } > + spin_unlock_irqrestore(&hif_dev->rx_lock, flags); > +} > + > static void ath9k_hif_usb_rx_stream(struct hif_device_usb *hif_dev, > struct sk_buff *skb) > { > @@ -1129,6 +1146,7 @@ static int ath9k_hif_usb_dev_init(struct hif_device_usb *hif_dev) > static void ath9k_hif_usb_dev_deinit(struct hif_device_usb *hif_dev) > { > ath9k_hif_usb_dealloc_urbs(hif_dev); > + ath9k_hif_usb_free_rx_remain_skb(hif_dev); > } Erm, does this actually fix the leak? AFAICT, ath9k_hif_usb_dev_deinit() is only called on the error path of ath9k_hif_usb_firmware_cb(), not when the device is subsequently torn down in ath9k_htc_disconnect_device()? I think the right place to put this is probably inside ath9k_hif_usb_dealloc_urbs()? That gets called on USB suspend as well, but it seems to me that if we're suspending the device to an extent that we're deallocating the urbs, we should be clearing out the cached skb in remain_skb anyway? -Toke
On 16.02.2023 19:15, Toke Høiland-Jørgensen wrote: > Erm, does this actually fix the leak? AFAICT, ath9k_hif_usb_dev_deinit() > is only called on the error path of ath9k_hif_usb_firmware_cb(), not > when the device is subsequently torn down in > ath9k_htc_disconnect_device()? ath9k_hif_usb_dev_deinit() is also called inside ath9k_hif_usb_disconnect(). I see it to be the only place wherehif_dev is freed (apart from an early error path), so the current patchimplementation actually fixes the leak. However, as you have noticed, itis not probably the best place to put the deallocation: we need to clearthe cached skb not only when freeing the device but in urbs deallocationcase, too - in order to avoid its irrelevant processing later. > I think the right place to put this is probably inside > ath9k_hif_usb_dealloc_urbs()? That gets called on USB suspend as well, > but it seems to me that if we're suspending the device to an extent that > we're deallocating the urbs, we should be clearing out the cached skb in > remain_skb anyway? > > -Toke Thank you for the advice! As I can see, remain_skb makes sense when receiving two consecutive urbs which are logically linked together, i.e. a specific data field from the first skb indicates a cached skb to be allocated, memcpy'd with some data and subsequently processed in the next call to rx callback (see 6ce708f54cc8 ("ath9k: Fix out-of-bound memcpy in ath9k_hif_usb_rx_stream")). Urbs deallocation, I suppose, makes that link irrelevant. So I agree with you that remain_skb freeing should be done when deallocating the urbs. I would just place that specifically into ath9k_hif_usb_dealloc_rx_urbs() as remain_skb is associated with rx urbs. RX_STAT_INC(hif_dev, skb_dropped), I think, should be also called when freeing afilled remain_skb? --- Regards, Fedor
Fedor Pchelkin <pchelkin@ispras.ru> writes: > On 16.02.2023 19:15, Toke Høiland-Jørgensen wrote: > > Erm, does this actually fix the leak? AFAICT, ath9k_hif_usb_dev_deinit() > > is only called on the error path of ath9k_hif_usb_firmware_cb(), not > > when the device is subsequently torn down in > > ath9k_htc_disconnect_device()? > > ath9k_hif_usb_dev_deinit() is also called inside > ath9k_hif_usb_disconnect(). No it's not, as of: f099c5c9e2ba ("wifi: ath9k: Fix use-after-free in ath9k_hif_usb_disconnect()") I guess you're looking at an older tree? Please base your patches on an up-to-date ath-next tree. > I see it to be the only place wherehif_dev is freed (apart from an > early error path), so the current patchimplementation actually fixes > the leak. However, as you have noticed, itis not probably the best > place to put the deallocation: we need to clearthe cached skb not only > when freeing the device but in urbs deallocationcase, too - in order > to avoid its irrelevant processing later. > > > I think the right place to put this is probably inside > > ath9k_hif_usb_dealloc_urbs()? That gets called on USB suspend as well, > > but it seems to me that if we're suspending the device to an extent that > > we're deallocating the urbs, we should be clearing out the cached skb in > > remain_skb anyway? > > > > -Toke > > Thank you for the advice! As I can see, remain_skb makes sense when > receiving two consecutive urbs which are logically linked together, i.e. > a specific data field from the first skb indicates a cached skb to be > allocated, memcpy'd with some data and subsequently processed in the > next call to rx callback (see 6ce708f54cc8 ("ath9k: Fix out-of-bound > memcpy in ath9k_hif_usb_rx_stream")). Urbs deallocation, I suppose, > makes that link irrelevant. > > So I agree with you that remain_skb freeing should be done when > deallocating the urbs. I would just place that specifically into > ath9k_hif_usb_dealloc_rx_urbs() as remain_skb is associated with rx > urbs. SGTM. > RX_STAT_INC(hif_dev, skb_dropped), I think, should be also called when > freeing afilled remain_skb? Well, if this is mostly something that happens if the device is going away I'm not sure that anyone will actually see that; but I suppose if it happens on suspend, the stat increase may be useful, and it shouldn't hurt otherwise, so sure, let's add that :) -Toke
On 16.02.2023 21:05, Toke Høiland-Jørgensen wrote: > Fedor Pchelkin <pchelkin@ispras.ru> writes: > >> On 16.02.2023 19:15, Toke Høiland-Jørgensen wrote: >> > Erm, does this actually fix the leak? AFAICT, ath9k_hif_usb_dev_deinit() >> > is only called on the error path of ath9k_hif_usb_firmware_cb(), not >> > when the device is subsequently torn down in >> > ath9k_htc_disconnect_device()? >> >> ath9k_hif_usb_dev_deinit() is also called inside >> ath9k_hif_usb_disconnect(). > No it's not, as of: > > f099c5c9e2ba ("wifi: ath9k: Fix use-after-free in ath9k_hif_usb_disconnect()") > > I guess you're looking at an older tree? Please base your patches on an > up-to-date ath-next tree. > Oops, that's my fault, I indeed patched the wrong tree. Thanks for clarifying!
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c index f521dfa2f194..e03ab972edf7 100644 --- a/drivers/net/wireless/ath/ath9k/hif_usb.c +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c @@ -534,6 +534,23 @@ static struct ath9k_htc_hif hif_usb = { .send = hif_usb_send, }; +/* Need to free remain_skb allocated in ath9k_hif_usb_rx_stream + * in case ath9k_hif_usb_rx_stream wasn't called next time to + * process the buffer and subsequently free it. + */ +static void ath9k_hif_usb_free_rx_remain_skb(struct hif_device_usb *hif_dev) +{ + unsigned long flags; + + spin_lock_irqsave(&hif_dev->rx_lock, flags); + if (hif_dev->remain_skb) { + dev_kfree_skb_any(hif_dev->remain_skb); + hif_dev->remain_skb = NULL; + hif_dev->rx_remain_len = 0; + } + spin_unlock_irqrestore(&hif_dev->rx_lock, flags); +} + static void ath9k_hif_usb_rx_stream(struct hif_device_usb *hif_dev, struct sk_buff *skb) { @@ -1129,6 +1146,7 @@ static int ath9k_hif_usb_dev_init(struct hif_device_usb *hif_dev) static void ath9k_hif_usb_dev_deinit(struct hif_device_usb *hif_dev) { ath9k_hif_usb_dealloc_urbs(hif_dev); + ath9k_hif_usb_free_rx_remain_skb(hif_dev); } /*
hif_dev->remain_skb is allocated and used exclusively in ath9k_hif_usb_rx_stream(). It is implied that an allocated remain_skb is processed and subsequently freed (in error paths) only during the next call of ath9k_hif_usb_rx_stream(). So, if the device is deinitialized between those two calls or if the skb contents are incorrect, it is possible that ath9k_hif_usb_rx_stream() is not called next time and the allocated remain_skb is leaked. Our local Syzkaller instance was able to trigger that. Fix the leak by introducing a function to explicitly free remain_skb (if it is not NULL) when the device is being deinitialized. remain_skb is NULL when it has not been allocated at all (hif_dev struct is kzalloced) or when it has been proccesed in next call to ath9k_hif_usb_rx_stream(). Proper spinlocks are held to prevent possible concurrent access to remain_skb from the interrupt context ath9k_hif_usb_rx_stream(). These accesses should not happen as rx_urbs have been deallocated before but it prevents a dangerous race condition in these cases. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.") Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- drivers/net/wireless/ath/ath9k/hif_usb.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)