| Message ID | 20230217030031.4021289-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 342fcde9d91460f01f65707e16368a1571271a3a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [-next] wifi: ath11k: fix return value check in ath11k_ahb_probe() | expand |
Yang Yingliang <yangyingliang@huawei.com> wrote: > ioremap() returns NULL pointer not PTR_ERR() when it fails, > so replace the IS_ERR() check with NULL pointer check. > > Fixes: b42b3678c91f ("wifi: ath11k: remap ce register space for IPQ5018") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 342fcde9d914 wifi: ath11k: fix return value check in ath11k_ahb_probe()
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index 920abce9053a..bad3946b44bf 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -1174,7 +1174,7 @@ static int ath11k_ahb_probe(struct platform_device *pdev) * to a new space for accessing them. */ ab->mem_ce = ioremap(ce_remap->base, ce_remap->size); - if (IS_ERR(ab->mem_ce)) { + if (!ab->mem_ce) { dev_err(&pdev->dev, "ce ioremap error\n"); ret = -ENOMEM; goto err_core_free;
ioremap() returns NULL pointer not PTR_ERR() when it fails, so replace the IS_ERR() check with NULL pointer check. Fixes: b42b3678c91f ("wifi: ath11k: remap ce register space for IPQ5018") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/wireless/ath/ath11k/ahb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)