| Message ID | 20230307104706.240119-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 488d9a484f96eee4f0e8e108aed42a057a1c7295 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: Add missing unwind goto in ath12k_pci_probe() | expand |
On Tue, Mar 07, 2023 at 02:47:06AM -0800, Harshit Mogalapalli wrote: > Smatch Warns: > drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() > warn: missing unwind goto? > > Store the error value in ret and use correct label with a goto. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/ > Suggested-by: Dan Carpenter <error27@gmail.com> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > Only Compile tested, found with Smatch. Reviewed-by: Simon Horman <simon.horman@corigine.com>
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > Smatch Warns: > drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() > warn: missing unwind goto? > > Store the error value in ret and use correct label with a goto. > > Only Compile tested, found with Smatch. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/ > Suggested-by: Dan Carpenter <error27@gmail.com> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 488d9a484f96 wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c index ae7f6083c9fc..f523aa15885f 100644 --- a/drivers/net/wireless/ath/ath12k/pci.c +++ b/drivers/net/wireless/ath/ath12k/pci.c @@ -1195,7 +1195,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev, dev_err(&pdev->dev, "Unknown hardware version found for QCN9274: 0x%x\n", soc_hw_version_major); - return -EOPNOTSUPP; + ret = -EOPNOTSUPP; + goto err_pci_free_region; } break; case WCN7850_DEVICE_ID:
Smatch Warns: drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() warn: missing unwind goto? Store the error value in ret and use correct label with a goto. Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/ Suggested-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- Only Compile tested, found with Smatch. --- drivers/net/wireless/ath/ath12k/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)