diff mbox series

wifi: ath11k: print a warning when crypto_alloc_shash() fails

Message ID 20230405090425.1351-1-kvalo@kernel.org (mailing list archive)
State Accepted
Commit a87a9110ac0dcbfd9458b6665c141fa1c16a669d
Delegated to: Kalle Valo
Headers show
Series wifi: ath11k: print a warning when crypto_alloc_shash() fails | expand

Commit Message

Kalle Valo April 5, 2023, 9:04 a.m. UTC 
From: Kalle Valo <quic_kvalo@quicinc.com>

Christoph reported that ath11k failed to initialise when michael_mic.ko
module was not installed. To make it easier to notice that case print a
warning when crypto_alloc_shash() fails.

Compile tested only.

Reported-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/all/20221130133016.GC3055@lst.de/
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: bea046575a2e6d7d1cf63cc7ab032647a3585de5

Comments

Kalle Valo April 17, 2023, 10:19 a.m. UTC | #1 
Kalle Valo <kvalo@kernel.org> wrote:

> Christoph reported that ath11k failed to initialise when michael_mic.ko
> module was not installed. To make it easier to notice that case print a
> warning when crypto_alloc_shash() fails.
> 
> Compile tested only.
> 
> Reported-by: Christoph Hellwig <hch@lst.de>
> Link: https://lore.kernel.org/all/20221130133016.GC3055@lst.de/
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

a87a9110ac0d wifi: ath11k: print a warning when crypto_alloc_shash() fails
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 99859b59138e..d22e5349c551 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -3106,8 +3106,11 @@  int ath11k_peer_rx_frag_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id
 	int i;
 
 	tfm = crypto_alloc_shash("michael_mic", 0, 0);
-	if (IS_ERR(tfm))
+	if (IS_ERR(tfm)) {
+		ath11k_warn(ab, "failed to allocate michael_mic shash: %ld\n",
+			    PTR_ERR(tfm));
 		return PTR_ERR(tfm);
+	}
 
 	spin_lock_bh(&ab->base_lock);