| Message ID | 20230421092200.24456-1-wangjikai@hust.edu.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f3dc7bb037d813ab7da84f488dd485f0fce66347 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] wifi: mt7601u: delete dead code checking debugfs returns | expand |
On Fri, 21 Apr 2023 09:22:00 +0000 Wang Jikai wrote: > Smatch reports that: > drivers/net/wireless/mediatek/mt7601u/debugfs.c:130 > mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid". > > Debugfs code is not supposed to need error checking so instead of > changing this to if (IS_ERR()) the correct thing is to just delete > the dead code. > > Signed-off-by: Wang Jikai <wangjikai@hust.edu.cn> Acked-by: Jakub Kicinski <kuba@kernel.org>
Wang Jikai <wangjikai@hust.edu.cn> wrote: > Smatch reports that: > drivers/net/wireless/mediatek/mt7601u/debugfs.c:130 > mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid". > > Debugfs code is not supposed to need error checking so instead of > changing this to if (IS_ERR()) the correct thing is to just delete > the dead code. > > Signed-off-by: Wang Jikai <wangjikai@hust.edu.cn> > Acked-by: Jakub Kicinski <kuba@kernel.org> Patch applied to wireless-next.git, thanks. f3dc7bb037d8 wifi: mt7601u: delete dead code checking debugfs returns
diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless/mediatek/mt7601u/debugfs.c index 230b0e1061a7..dbddf256921b 100644 --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c @@ -127,8 +127,6 @@ void mt7601u_init_debugfs(struct mt7601u_dev *dev) struct dentry *dir; dir = debugfs_create_dir("mt7601u", dev->hw->wiphy->debugfsdir); - if (!dir) - return; debugfs_create_u8("temperature", 0400, dir, &dev->raw_temp); debugfs_create_u32("temp_mode", 0400, dir, &dev->temp_mode);
Smatch reports that: drivers/net/wireless/mediatek/mt7601u/debugfs.c:130 mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid". Debugfs code is not supposed to need error checking so instead of changing this to if (IS_ERR()) the correct thing is to just delete the dead code. Signed-off-by: Wang Jikai <wangjikai@hust.edu.cn> --- v1 -> v2: not add redundant removal of debugfs dir. remove fixes tag. The issue is found by static analysis and remains untested. --- drivers/net/wireless/mediatek/mt7601u/debugfs.c | 2 -- 1 file changed, 2 deletions(-)