| Message ID | 20230509100420.26094-1-matthias.bgg@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 87807f77a03d0271211b75f84b2a8b88f4e8e5d4 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: brcmfmac: wcc: Add debug messages | expand |
Hi, On 5/9/23 12:04, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > The message is attach and detach function are merly for debugging, > change them from pr_err to pr_debug. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> Thank you, I had writing this same patch on my own TODO list :) Patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c > index 02de99818efa..5573a47766ad 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c > @@ -12,13 +12,13 @@ > > static int brcmf_wcc_attach(struct brcmf_pub *drvr) > { > - pr_err("%s: executing\n", __func__); > + pr_debug("%s: executing\n", __func__); > return 0; > } > > static void brcmf_wcc_detach(struct brcmf_pub *drvr) > { > - pr_err("%s: executing\n", __func__); > + pr_debug("%s: executing\n", __func__); > } > > const struct brcmf_fwvid_ops brcmf_wcc_ops = {
matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > The message is attach and detach function are merly for debugging, > change them from pr_err to pr_debug. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > Reviewed-by: Hans de Goede <hdegoede@redhat.com> Patch applied to wireless-next.git, thanks. 87807f77a03d wifi: brcmfmac: wcc: Add debug messages
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c index 02de99818efa..5573a47766ad 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c @@ -12,13 +12,13 @@ static int brcmf_wcc_attach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_debug("%s: executing\n", __func__); return 0; } static void brcmf_wcc_detach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_debug("%s: executing\n", __func__); } const struct brcmf_fwvid_ops brcmf_wcc_ops = {