diff mbox series

[wireless-next,2/2] brcmutil: use helper function pktq_empty() instead of open code

Message ID 20230527114954.3281-2-claudiajkang@gmail.com (mailing list archive)
State Accepted
Commit 8012ec4a0e64b60d4d782950296e6fb217c6758f
Delegated to: Kalle Valo
Headers show
Series [wireless-next,1/2] wifi: rtlwifi: use helper function rtl_get_hdr() | expand

Commit Message

Juhee Kang May 27, 2023, 11:49 a.m. UTC
pktq_empty was added in commit 5b435de0d786 ("net: wireless: add brcm80211
drivers") but it is currently not being utilized in some areas. This commit
replaces the open code with the pktq_empty() function.

Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmutil/utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman May 27, 2023, 2:56 p.m. UTC | #1
On Sat, May 27, 2023 at 08:49:54PM +0900, Juhee Kang wrote:
> pktq_empty was added in commit 5b435de0d786 ("net: wireless: add brcm80211
> drivers") but it is currently not being utilized in some areas. This commit
> replaces the open code with the pktq_empty() function.
> 
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmutil/utils.c b/drivers/net/wireless/broadcom/brcm80211/brcmutil/utils.c
index e87e68cc46e2..fe94db0ba3f3 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmutil/utils.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmutil/utils.c
@@ -186,7 +186,7 @@  struct sk_buff *brcmu_pktq_peek_tail(struct pktq *pq, int *prec_out)
 {
 	int prec;
 
-	if (pq->len == 0)
+	if (pktq_empty(pq))
 		return NULL;
 
 	for (prec = 0; prec < pq->hi_prec; prec++)
@@ -223,7 +223,7 @@  struct sk_buff *brcmu_pktq_mdeq(struct pktq *pq, uint prec_bmp,
 	struct sk_buff *p;
 	int prec;
 
-	if (pq->len == 0)
+	if (pktq_empty(pq))
 		return NULL;
 
 	while ((prec = pq->hi_prec) > 0 &&