diff mbox series

wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown

Message ID 20230527222859.273768-1-marex@denx.de (mailing list archive)
State Accepted
Commit e74f562328b03fbe9cf438f958464dff3a644dfc
Delegated to: Kalle Valo
Headers show
Series wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown | expand

Commit Message

Marek Vasut May 27, 2023, 10:28 p.m. UTC
It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
indicates to the MMC subsystem to keep the slot powered on during
suspend, but in shutdown the slot should actually be powered off.
Drop this call.

Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Marek Vasut <marex@denx.de>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
---
 drivers/net/wireless/rsi/rsi_91x_sdio.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Horman May 30, 2023, 7:39 a.m. UTC | #1
On Sun, May 28, 2023 at 12:28:59AM +0200, Marek Vasut wrote:
> It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
> indicates to the MMC subsystem to keep the slot powered on during
> suspend, but in shutdown the slot should actually be powered off.
> Drop this call.
> 
> Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Kalle Valo June 8, 2023, 4:02 p.m. UTC | #2
Marek Vasut <marex@denx.de> wrote:

> It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
> indicates to the MMC subsystem to keep the slot powered on during
> suspend, but in shutdown the slot should actually be powered off.
> Drop this call.
> 
> Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Patch applied to wireless-next.git, thanks.

e74f562328b0 wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
diff mbox series

Patch

diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c
index 6e33a2563fdbd..1911fef3bbad6 100644
--- a/drivers/net/wireless/rsi/rsi_91x_sdio.c
+++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c
@@ -1479,9 +1479,6 @@  static void rsi_shutdown(struct device *dev)
 	if (sdev->write_fail)
 		rsi_dbg(INFO_ZONE, "###### Device is not ready #######\n");
 
-	if (rsi_set_sdio_pm_caps(adapter))
-		rsi_dbg(INFO_ZONE, "Setting power management caps failed\n");
-
 	rsi_dbg(INFO_ZONE, "***** RSI module shut down *****\n");
 }