diff mbox series

wifi: p54: Add missing MODULE_FIRMWARE macro

Message ID 20230616121917.1034761-1-juerg.haefliger@canonical.com (mailing list archive)
State Accepted
Commit 8d0c7e1901d6083756b7530d348cb0af6b25ded8
Delegated to: Kalle Valo
Headers show
Series wifi: p54: Add missing MODULE_FIRMWARE macro | expand

Commit Message

Juerg Haefliger June 16, 2023, 12:19 p.m. UTC
Add the missing MODULE_FIRMWARE macro for "3826.eeprom".

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 drivers/net/wireless/intersil/p54/p54spi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christian Lamparter June 16, 2023, 1:05 p.m. UTC | #1
On 6/16/23 14:19, Juerg Haefliger wrote:
> Add the missing MODULE_FIRMWARE macro for "3826.eeprom".
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Sure.

Acked-by: Christian Lamparter <chunkeey@gmail.com>

For people looking for the "3826.eeprom": Default values
are provided by p54spi_eeprom.h . But there's a MAC field
and antennas dbi values in there for customization.

Cheers,
Christian
> ---
>   drivers/net/wireless/intersil/p54/p54spi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
> index 19152fd449ba..ce0179b8ab36 100644
> --- a/drivers/net/wireless/intersil/p54/p54spi.c
> +++ b/drivers/net/wireless/intersil/p54/p54spi.c
> @@ -28,6 +28,7 @@
>   #endif /* CONFIG_P54_SPI_DEFAULT_EEPROM */
>   
>   MODULE_FIRMWARE("3826.arm");
> +MODULE_FIRMWARE("3826.eeprom");
>   
>   /* gpios should be handled in board files and provided via platform data,
>    * but because it's currently impossible for p54spi to have a header file
Kalle Valo June 21, 2023, 9:53 a.m. UTC | #2
Juerg Haefliger <juerg.haefliger@canonical.com> wrote:

> Add the missing MODULE_FIRMWARE macro for "3826.eeprom".
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>

Patch applied to wireless-next.git, thanks.

8d0c7e1901d6 wifi: p54: Add missing MODULE_FIRMWARE macro
diff mbox series

Patch

diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
index 19152fd449ba..ce0179b8ab36 100644
--- a/drivers/net/wireless/intersil/p54/p54spi.c
+++ b/drivers/net/wireless/intersil/p54/p54spi.c
@@ -28,6 +28,7 @@ 
 #endif /* CONFIG_P54_SPI_DEFAULT_EEPROM */
 
 MODULE_FIRMWARE("3826.arm");
+MODULE_FIRMWARE("3826.eeprom");
 
 /* gpios should be handled in board files and provided via platform data,
  * but because it's currently impossible for p54spi to have a header file