| Message ID | 20230713040518.13734-1-machel@vivo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net,v1] ath6kl:Fix error checking for debugfs_create_dir() | expand |
On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote: > The debugfs_create_dir() function returns error pointers, > it never returns NULL. Most incorrect error checks were fixed, > but the one in ath6kl_debug_init_fs() was forgotten. > > Fix the remaining error check. > > Signed-off-by: Wang Ming <machel@vivo.com> > > Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") The SoB tag should be after the 'Fixes' one and you must avoid empty lines in between. (The same applies to your other patch) Cheers, Paolo
On Thu, 2023-07-13 at 09:31 +0000, 王明-软件底层技术部 wrote: > Thank you for pointing out, I will pay attention to it in the future. > In addition, do I need to modify this patch and submit it again? Yes, a v2 is needed. There are a few patches on this same topic, and I read only now what Simon noted: https://lore.kernel.org/linux-wireless/ZG8YY%2Fr8BLCzw93q@corigine.com/ so, the current code is likely not really buggy, and a possible cleanup patch (such patch would _not_ be a fix) could simply remove the check altogether. Cheers, Paolo
Paolo Abeni <pabeni@redhat.com> writes: > On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote: >> The debugfs_create_dir() function returns error pointers, >> it never returns NULL. Most incorrect error checks were fixed, >> but the one in ath6kl_debug_init_fs() was forgotten. >> >> Fix the remaining error check. >> >> Signed-off-by: Wang Ming <machel@vivo.com> >> >> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") > > The SoB tag should be after the 'Fixes' one and you must avoid empty > lines in between. > > (The same applies to your other patch) And the same as with the ath9k patch: this should go to ath-next, not net.
diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c index 433a047f3747..505af195e299 100644 --- a/drivers/net/wireless/ath/ath6kl/debug.c +++ b/drivers/net/wireless/ath/ath6kl/debug.c @@ -1793,7 +1793,7 @@ int ath6kl_debug_init_fs(struct ath6kl *ar) { ar->debugfs_phy = debugfs_create_dir("ath6kl", ar->wiphy->debugfsdir); - if (!ar->debugfs_phy) + if (IS_ERR(ar->debugfs_phy)) return -ENOMEM; debugfs_create_file("tgt_stats", 0400, ar->debugfs_phy, ar,
The debugfs_create_dir() function returns error pointers, it never returns NULL. Most incorrect error checks were fixed, but the one in ath6kl_debug_init_fs() was forgotten. Fix the remaining error check. Signed-off-by: Wang Ming <machel@vivo.com> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") --- drivers/net/wireless/ath/ath6kl/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)