| Message ID | 20230914160744.155903-1-dmantipov@yandex.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 30e7099a6dc95e46f94609d0fba787b9deb369a6 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath10k: drop HTT_DATA_TX_STATUS_DOWNLOAD_FAIL | expand |
On 9/14/2023 9:07 AM, Dmitry Antipov wrote: > According to Jeff, 'HTT_DATA_TX_STATUS_DOWNLOAD_FAIL' from > 'enum htt_data_tx_status' is never actually used by the > firmware code and so may be dropped, with the related > adjustment to 'ath10k_htt_rx_tx_compl_ind()'. > > Suggested-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > --- > drivers/net/wireless/ath/ath10k/htt.h | 3 +-- > drivers/net/wireless/ath/ath10k/htt_rx.c | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h > index 7b24297146e7..c80470e8886a 100644 > --- a/drivers/net/wireless/ath/ath10k/htt.h > +++ b/drivers/net/wireless/ath/ath10k/htt.h > @@ -880,8 +880,7 @@ enum htt_data_tx_status { > HTT_DATA_TX_STATUS_OK = 0, > HTT_DATA_TX_STATUS_DISCARD = 1, > HTT_DATA_TX_STATUS_NO_ACK = 2, > - HTT_DATA_TX_STATUS_POSTPONE = 3, /* HL only */ > - HTT_DATA_TX_STATUS_DOWNLOAD_FAIL = 128 > + HTT_DATA_TX_STATUS_POSTPONE = 3 /* HL only */ > }; > > enum htt_data_tx_flags { > diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c > index 438b0caaceb7..b261d6371c0f 100644 > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c > @@ -2964,7 +2964,6 @@ static void ath10k_htt_rx_tx_compl_ind(struct ath10k *ar, > break; > case HTT_DATA_TX_STATUS_DISCARD: > case HTT_DATA_TX_STATUS_POSTPONE: > - case HTT_DATA_TX_STATUS_DOWNLOAD_FAIL: > tx_done.status = HTT_TX_COMPL_STATE_DISCARD; > break; > default:
Dmitry Antipov <dmantipov@yandex.ru> wrote: > According to Jeff, 'HTT_DATA_TX_STATUS_DOWNLOAD_FAIL' from > 'enum htt_data_tx_status' is never actually used by the > firmware code and so may be dropped, with the related > adjustment to 'ath10k_htt_rx_tx_compl_ind()'. > > Suggested-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 30e7099a6dc9 wifi: ath10k: drop HTT_DATA_TX_STATUS_DOWNLOAD_FAIL
diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h index 7b24297146e7..c80470e8886a 100644 --- a/drivers/net/wireless/ath/ath10k/htt.h +++ b/drivers/net/wireless/ath/ath10k/htt.h @@ -880,8 +880,7 @@ enum htt_data_tx_status { HTT_DATA_TX_STATUS_OK = 0, HTT_DATA_TX_STATUS_DISCARD = 1, HTT_DATA_TX_STATUS_NO_ACK = 2, - HTT_DATA_TX_STATUS_POSTPONE = 3, /* HL only */ - HTT_DATA_TX_STATUS_DOWNLOAD_FAIL = 128 + HTT_DATA_TX_STATUS_POSTPONE = 3 /* HL only */ }; enum htt_data_tx_flags { diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 438b0caaceb7..b261d6371c0f 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -2964,7 +2964,6 @@ static void ath10k_htt_rx_tx_compl_ind(struct ath10k *ar, break; case HTT_DATA_TX_STATUS_DISCARD: case HTT_DATA_TX_STATUS_POSTPONE: - case HTT_DATA_TX_STATUS_DOWNLOAD_FAIL: tx_done.status = HTT_TX_COMPL_STATE_DISCARD; break; default:
According to Jeff, 'HTT_DATA_TX_STATUS_DOWNLOAD_FAIL' from 'enum htt_data_tx_status' is never actually used by the firmware code and so may be dropped, with the related adjustment to 'ath10k_htt_rx_tx_compl_ind()'. Suggested-by: Jeff Johnson <quic_jjohnson@quicinc.com> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Found by Linux Verification Center (linuxtesting.org) with SVACE. --- drivers/net/wireless/ath/ath10k/htt.h | 3 +-- drivers/net/wireless/ath/ath10k/htt_rx.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-)