| Message ID | 20230914211938.28395-1-victor.gonzalo@anddroptable.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 260323c3a3e3f0adf5a4f1ab0fcf05b2dbcc768d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata | expand |
On Fri, Sep 15, 2023 at 12:19:38AM +0300, Víctor Gonzalo wrote: > The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to > add the firmware files needed to the module metadata. > > Signed-off-by: Víctor Gonzalo <victor.gonzalo@anddroptable.net> > --- > drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++ > 1 file changed, 6 insertions(+) FWIW, when reviewing the other sub-drivers, I noticed sdio.c is missing an entry for SD8801_DEFAULT_FW_NAME. Mind sending a patch? For this: Acked-by: Brian Norris <briannorris@chromium.org>
Víctor Gonzalo <victor.gonzalo@anddroptable.net> wrote: > The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to > add the firmware files needed to the module metadata. > > Signed-off-by: Víctor Gonzalo <victor.gonzalo@anddroptable.net> > Acked-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-next.git, thanks. 260323c3a3e3 wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 6697132ecc97..cd464453d5db 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -3449,3 +3449,9 @@ MODULE_AUTHOR("Marvell International Ltd."); MODULE_DESCRIPTION("Marvell WiFi-Ex PCI-Express Driver version " PCIE_VERSION); MODULE_VERSION(PCIE_VERSION); MODULE_LICENSE("GPL v2"); +MODULE_FIRMWARE(PCIE8766_DEFAULT_FW_NAME); +MODULE_FIRMWARE(PCIE8897_DEFAULT_FW_NAME); +MODULE_FIRMWARE(PCIE8897_A0_FW_NAME); +MODULE_FIRMWARE(PCIE8897_B0_FW_NAME); +MODULE_FIRMWARE(PCIEUART8997_FW_NAME_V4); +MODULE_FIRMWARE(PCIEUSB8997_FW_NAME_V4);
The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to add the firmware files needed to the module metadata. Signed-off-by: Víctor Gonzalo <victor.gonzalo@anddroptable.net> --- drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++ 1 file changed, 6 insertions(+)