| Message ID | 20231102115606.69838-1-dmantipov@yandex.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ed4f0c195e8fba06fa5c1072ade7feaadb91c03d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: rtw88: simplify __rtw_tx_work() | expand |
> -----Original Message----- > From: Dmitry Antipov <dmantipov@yandex.ru> > Sent: Thursday, November 2, 2023 7:56 PM > To: Ping-Ke Shih <pkshih@realtek.com> > Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru> > Subject: [PATCH] wifi: rtw88: simplify __rtw_tx_work() > > Since 'ieee80211_txq_get_depth()' allows NULL for 2nd and > 3rd arguments, simplify '__rtw_tx_work()' by dropping unused > 'byte_cnt'. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Dmitry Antipov <dmantipov@yandex.ru> wrote: > Since 'ieee80211_txq_get_depth()' allows NULL for 2nd and > 3rd arguments, simplify '__rtw_tx_work()' by dropping unused > 'byte_cnt'. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. ed4f0c195e8f wifi: rtw88: simplify __rtw_tx_work()
diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c index f63900b6621d..c02ac673be32 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.c +++ b/drivers/net/wireless/realtek/rtw88/tx.c @@ -656,9 +656,8 @@ void __rtw_tx_work(struct rtw_dev *rtwdev) list_for_each_entry_safe(rtwtxq, tmp, &rtwdev->txqs, list) { struct ieee80211_txq *txq = rtwtxq_to_txq(rtwtxq); unsigned long frame_cnt; - unsigned long byte_cnt; - ieee80211_txq_get_depth(txq, &frame_cnt, &byte_cnt); + ieee80211_txq_get_depth(txq, &frame_cnt, NULL); rtw_txq_push(rtwdev, rtwtxq, frame_cnt); list_del_init(&rtwtxq->list);
Since 'ieee80211_txq_get_depth()' allows NULL for 2nd and 3rd arguments, simplify '__rtw_tx_work()' by dropping unused 'byte_cnt'. Compile tested only. Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> --- drivers/net/wireless/realtek/rtw88/tx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)