diff mbox series

[1/2] wifi: ath11k: Remove struct ath11k::ops

Message ID 20231106-ath12k-remove-ieee80211_ops-v1-1-d72cef1a855b@quicinc.com (mailing list archive)
State Accepted
Commit 199a78565cc2bf3fee530cade297e309de5a1f3a
Delegated to: Kalle Valo
Headers show
Series wifi: ath: Remove unused struct ieee80211_ops *ops | expand

Commit Message

Jeff Johnson Nov. 6, 2023, 6:21 p.m. UTC
Currently struct ath11k defines the following member:
        struct ieee80211_ops *ops;

This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const

The original plan was to add the const qualifier.  However, it turns
out this is actually unused, so remove it.

No functional changes, compile tested only.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/core.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Nov. 22, 2023, 6:24 p.m. UTC | #1
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:

> Currently struct ath11k defines the following member:
>         struct ieee80211_ops *ops;
> 
> This is being flagged by checkpatch.pl:
> WARNING: struct ieee80211_ops should normally be const
> 
> The original plan was to add the const qualifier.  However, it turns
> out this is actually unused, so remove it.
> 
> No functional changes, compile tested only.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

2 patches applied to ath-next branch of ath.git, thanks.

199a78565cc2 wifi: ath11k: Remove struct ath11k::ops
3b6ec0409fe8 wifi: ath12k: Remove struct ath12k::ops
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index f12b606e2d2e..7e3b6779f4e9 100644
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -599,7 +599,6 @@  struct ath11k {
 	struct ath11k_base *ab;
 	struct ath11k_pdev *pdev;
 	struct ieee80211_hw *hw;
-	struct ieee80211_ops *ops;
 	struct ath11k_pdev_wmi *wmi;
 	struct ath11k_pdev_dp dp;
 	u8 mac_addr[ETH_ALEN];