| Message ID | 20231113153544.282461-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a466027abe4af3a39bf1d450e8cacd34a63b7edf |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC | expand |
On 11/13/2023 7:35 AM, James Prestwood wrote: > Let ath11k select this option automatically which makes building > more intuitive if the user enables this driver (rather than the > driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled) s/MICAEL/MICHAEL/ add hard stop Also suggest you include (or summarize) the information that Kalle shared that ath is the outlier here: Further investigation shows that ath11k and ath12k are the only who use 'depends on' with CRYPTO_MICHAEL_MIC: ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC consider these comments apply to ath12k change as well :) > > Signed-off-by: James Prestwood <prestwoj@gmail.com> > --- > drivers/net/wireless/ath/ath11k/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/Kconfig b/drivers/net/wireless/ath/ath11k/Kconfig > index ad5cc6cac05b..27f0523bf967 100644 > --- a/drivers/net/wireless/ath/ath11k/Kconfig > +++ b/drivers/net/wireless/ath/ath11k/Kconfig > @@ -2,7 +2,7 @@ > config ATH11K > tristate "Qualcomm Technologies 802.11ax chipset support" > depends on MAC80211 && HAS_DMA > - depends on CRYPTO_MICHAEL_MIC > + select CRYPTO_MICHAEL_MIC > select ATH_COMMON > select QCOM_QMI_HELPERS > help
Jeff Johnson <quic_jjohnson@quicinc.com> writes: > On 11/13/2023 7:35 AM, James Prestwood wrote: >> Let ath11k select this option automatically which makes building >> more intuitive if the user enables this driver (rather than the >> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled) > > s/MICAEL/MICHAEL/ > > add hard stop > > Also suggest you include (or summarize) the information that Kalle > shared that ath is the outlier here: > > Further investigation shows that ath11k and ath12k are the only who use > 'depends on' with CRYPTO_MICHAEL_MIC: > > ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC > ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC > > consider these comments apply to ath12k change as well :) BTW I can add these changes in the pending branch, no need to resend because of this.
On 11/20/23 01:14, Kalle Valo wrote: > Jeff Johnson <quic_jjohnson@quicinc.com> writes: > >> On 11/13/2023 7:35 AM, James Prestwood wrote: >>> Let ath11k select this option automatically which makes building >>> more intuitive if the user enables this driver (rather than the >>> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled) >> s/MICAEL/MICHAEL/ >> >> add hard stop >> >> Also suggest you include (or summarize) the information that Kalle >> shared that ath is the outlier here: >> >> Further investigation shows that ath11k and ath12k are the only who use >> 'depends on' with CRYPTO_MICHAEL_MIC: >> >> ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC >> ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC >> ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC >> ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC >> ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC >> ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC >> ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC >> >> consider these comments apply to ath12k change as well :) > BTW I can add these changes in the pending branch, no need to resend > because of this. Works for me. Had a few things come up and hadn't circled back here yet. Thanks, James
James Prestwood <prestwoj@gmail.com> wrote: > Let ath11k select this option automatically which makes building > more intuitive if the user enables this driver (rather than the > driver not building unless CRYPTO_MICHAEL_MIC is explicitly enabled). > > Further investigation shows that ath11k and ath12k are the only who use > 'depends on' with CRYPTO_MICHAEL_MIC: > > ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC > ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC > > Signed-off-by: James Prestwood <prestwoj@gmail.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 2 patches applied to ath-next branch of ath.git, thanks. a466027abe4a wifi: ath11k: use select for CRYPTO_MICHAEL_MIC c7b4f54112e1 wifi: ath12k: use select for CRYPTO_MICHAEL_MIC
diff --git a/drivers/net/wireless/ath/ath11k/Kconfig b/drivers/net/wireless/ath/ath11k/Kconfig index ad5cc6cac05b..27f0523bf967 100644 --- a/drivers/net/wireless/ath/ath11k/Kconfig +++ b/drivers/net/wireless/ath/ath11k/Kconfig @@ -2,7 +2,7 @@ config ATH11K tristate "Qualcomm Technologies 802.11ax chipset support" depends on MAC80211 && HAS_DMA - depends on CRYPTO_MICHAEL_MIC + select CRYPTO_MICHAEL_MIC select ATH_COMMON select QCOM_QMI_HELPERS help
Let ath11k select this option automatically which makes building more intuitive if the user enables this driver (rather than the driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled) Signed-off-by: James Prestwood <prestwoj@gmail.com> --- drivers/net/wireless/ath/ath11k/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)