diff mbox series

[1/2] wifi: rtl8xxxu: convert EN_DESC_ID of TX descriptor to le32 type

Message ID 20240116080945.20172-1-pkshih@realtek.com (mailing list archive)
State Accepted
Commit 426e7b4773921d07ab4ab8ba16fbad396d6c9971
Delegated to: Kalle Valo
Headers show
Series [1/2] wifi: rtl8xxxu: convert EN_DESC_ID of TX descriptor to le32 type | expand

Commit Message

Ping-Ke Shih Jan. 16, 2024, 8:09 a.m. UTC
Fields of TX descriptor are little-endian order, so correct EN_DESC_ID
field to le32 type.

Fixes: b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP mode")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401161318.YtXoCkjU-lkp@intel.com/
Cc: Martin Kaistra <martin.kaistra@linutronix.de>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Jan. 18, 2024, 9:37 a.m. UTC | #1
Ping-Ke Shih <pkshih@realtek.com> wrote:

> Fields of TX descriptor are little-endian order, so correct EN_DESC_ID
> field to le32 type.
> 
> Fixes: b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP mode")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401161318.YtXoCkjU-lkp@intel.com/
> Cc: Martin Kaistra <martin.kaistra@linutronix.de>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

2 patches applied to wireless-next.git, thanks.

426e7b477392 wifi: rtl8xxxu: convert EN_DESC_ID of TX descriptor to le32 type
92c7428f942d wifi: rtl8xxxu: make instances of iface limit and combination to be static const
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 521faa48803c..98700f3ad6f9 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5619,7 +5619,7 @@  static void rtl8xxxu_tx(struct ieee80211_hw *hw,
 			break;
 		}
 		if (bmc && rtlvif->hw_key_idx != 0xff) {
-			tx_desc->txdw1 |= TXDESC_EN_DESC_ID;
+			tx_desc->txdw1 |= cpu_to_le32(TXDESC_EN_DESC_ID);
 			macid = rtlvif->hw_key_idx;
 		}
 	}