| Message ID | 20240313001305.18820-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6c700b35a5340020e8fa9925871f7e1ed365ab92 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ssb: use "break" on default case to prevent warning | expand |
On Tue, 12 Mar 2024 17:13:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > --- a/drivers/ssb/main.c > +++ b/drivers/ssb/main.c > @@ -1144,6 +1144,7 @@ u32 ssb_dma_translation(struct ssb_devic > return SSB_PCI_DMA; > } > default: > + break; > } > return 0; > } > Acked-by: Michael Büsch <m@bues.ch>
On Tue, Mar 12, 2024 at 05:13:03PM -0700, Randy Dunlap wrote: > Having an empty default: case in a switch statement causes a warning > (when using Clang; I don't see the warning when using gcc), > so add a "break;" to the default case to prevent the warning: > > drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions] It is a hard error with earlier versions of clang as well: drivers/ssb/main.c:1148:10: error: label at end of compound statement: expected statement default: ^ ; 1 error generated. > Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@intel.com/ > Cc: Michael Büsch <m@bues.ch> > Cc: linux-wireless@vger.kernel.org > Cc: Kalle Valo <kvalo@kernel.org> > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: llvm@lists.linux.dev Thanks for the quick fix! Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/ssb/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/ssb/main.c b/drivers/ssb/main.c > --- a/drivers/ssb/main.c > +++ b/drivers/ssb/main.c > @@ -1144,6 +1144,7 @@ u32 ssb_dma_translation(struct ssb_devic > return SSB_PCI_DMA; > } > default: > + break; > } > return 0; > } >
Randy Dunlap <rdunlap@infradead.org> wrote: > Having an empty default: case in a switch statement causes a warning > (when using Clang; I don't see the warning when using gcc), > so add a "break;" to the default case to prevent the warning: > > drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions] > > Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@intel.com/ > Cc: Michael Büsch <m@bues.ch> > Cc: linux-wireless@vger.kernel.org > Cc: Kalle Valo <kvalo@kernel.org> > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: llvm@lists.linux.dev > Acked-by: Michael Büsch <m@bues.ch> > Reviewed-by: Nathan Chancellor <nathan@kernel.org> Patch applied to wireless-next.git, thanks. 6c700b35a534 ssb: use "break" on default case to prevent warning
diff -- a/drivers/ssb/main.c b/drivers/ssb/main.c --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -1144,6 +1144,7 @@ u32 ssb_dma_translation(struct ssb_devic return SSB_PCI_DMA; } default: + break; } return 0; }
Having an empty default: case in a switch statement causes a warning (when using Clang; I don't see the warning when using gcc), so add a "break;" to the default case to prevent the warning: drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions] Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@intel.com/ Cc: Michael Büsch <m@bues.ch> Cc: linux-wireless@vger.kernel.org Cc: Kalle Valo <kvalo@kernel.org> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: llvm@lists.linux.dev --- drivers/ssb/main.c | 1 + 1 file changed, 1 insertion(+)