| Message ID | 20240427162644.2470886-2-quic_tamizhr@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: Remove unsupported and unused ring configurations | expand |
On 4/27/2024 9:56 PM, Tamizh Chelvam Raja wrote: > Currently in ath12k_dp_tx_htt_monitor_mode_ring_config() > ath12k_dp_tx_htt_tx_monitor_mode_ring_config() function wrongly called twice. > Fix that by calling ath12k_dp_tx_htt_rx_monitor_mode_ring_config(). > > Currently monitor mode is disabled in driver so the change is compile > tested and boot sequence verified. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c > index 9b6d7d72f57c..2fb9fc42db11 100644 > --- a/drivers/net/wireless/ath/ath12k/dp_tx.c > +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c > @@ -1044,7 +1044,7 @@ int ath12k_dp_tx_htt_monitor_mode_ring_config(struct ath12k *ar, bool reset) > struct ath12k_base *ab = ar->ab; > int ret; > > - ret = ath12k_dp_tx_htt_tx_monitor_mode_ring_config(ar, reset); > + ret = ath12k_dp_tx_htt_rx_monitor_mode_ring_config(ar, reset); > if (ret) { > ath12k_err(ab, "failed to setup tx monitor filter %d\n", ret); > return ret; Looks like you modifying in wrong place because the debug log information is not matching the rx message. no ?
diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c index 9b6d7d72f57c..2fb9fc42db11 100644 --- a/drivers/net/wireless/ath/ath12k/dp_tx.c +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c @@ -1044,7 +1044,7 @@ int ath12k_dp_tx_htt_monitor_mode_ring_config(struct ath12k *ar, bool reset) struct ath12k_base *ab = ar->ab; int ret; - ret = ath12k_dp_tx_htt_tx_monitor_mode_ring_config(ar, reset); + ret = ath12k_dp_tx_htt_rx_monitor_mode_ring_config(ar, reset); if (ret) { ath12k_err(ab, "failed to setup tx monitor filter %d\n", ret); return ret;
Currently in ath12k_dp_tx_htt_monitor_mode_ring_config() ath12k_dp_tx_htt_tx_monitor_mode_ring_config() function wrongly called twice. Fix that by calling ath12k_dp_tx_htt_rx_monitor_mode_ring_config(). Currently monitor mode is disabled in driver so the change is compile tested and boot sequence verified. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> --- drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)