| Message ID | 20240529043043.2488031-2-quic_adisi@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8dd65ccbdf91e2fe3ab6e4da158b38f81746c3b4 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: fixes for per pdev debugfs | expand |
On 5/28/2024 9:30 PM, Aditya Kumar Singh wrote: > Function ath12k_debugfs_register() is called once inside the function > ath12k_mac_hw_register(). However, with single wiphy model, there could > be multiple pdevs registered under single hardware. Hence, need to register > debugfs for each one of them. > > Move the caller inside the loop which iterates over all underlying pdevs. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Fixes: f8bde02a26b9 ("wifi: ath12k: initial debugfs support") > Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Aditya Kumar Singh <quic_adisi@quicinc.com> wrote: > Function ath12k_debugfs_register() is called once inside the function > ath12k_mac_hw_register(). However, with single wiphy model, there could > be multiple pdevs registered under single hardware. Hence, need to register > debugfs for each one of them. > > Move the caller inside the loop which iterates over all underlying pdevs. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Fixes: f8bde02a26b9 ("wifi: ath12k: initial debugfs support") > Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 3 patches applied to ath-next branch of ath.git, thanks. 8dd65ccbdf91 wifi: ath12k: fix per pdev debugfs registration 4e1eff38d37a wifi: ath12k: unregister per pdev debugfs 5a16da9cfb40 wifi: ath12k: handle symlink cleanup for per pdev debugfs dentry
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 784964ae03ec..beec42d4ec24 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -9077,9 +9077,9 @@ static int ath12k_mac_hw_register(struct ath12k_hw *ah) ath12k_err(ar->ab, "ath12k regd update failed: %d\n", ret); goto err_unregister_hw; } - } - ath12k_debugfs_register(ar); + ath12k_debugfs_register(ar); + } return 0;
Function ath12k_debugfs_register() is called once inside the function ath12k_mac_hw_register(). However, with single wiphy model, there could be multiple pdevs registered under single hardware. Hence, need to register debugfs for each one of them. Move the caller inside the loop which iterates over all underlying pdevs. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Fixes: f8bde02a26b9 ("wifi: ath12k: initial debugfs support") Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com> --- drivers/net/wireless/ath/ath12k/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)