diff mbox series

[1/2] wifi: rtw88: select WANT_DEV_COREDUMP

Message ID 20240718070616.42217-1-pkshih@realtek.com (mailing list archive)
State Accepted
Delegated to: Ping-Ke Shih
Headers show
Series [1/2] wifi: rtw88: select WANT_DEV_COREDUMP | expand

Commit Message

Ping-Ke Shih July 18, 2024, 7:06 a.m. UTC 
From: Zong-Zhe Yang <kevin_yang@realtek.com>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo July 30, 2024, 1:08 p.m. UTC | #1 
Ping-Ke Shih <pkshih@realtek.com> writes:

> From: Zong-Zhe Yang <kevin_yang@realtek.com>
>
> We have invoked device coredump when fw crash.
> Should select WANT_DEV_COREDUMP by ourselves.
>
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Should these two go to wireless tree? If yes, please assign the patches
to me on patchwork. But rtw tree is fine for me as well, your call.
Ping-Ke Shih July 31, 2024, 12:38 a.m. UTC | #2 
Kalle Valo <kvalo@kernel.org> wrote:
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
> >
> > We have invoked device coredump when fw crash.
> > Should select WANT_DEV_COREDUMP by ourselves.
> >
> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> Should these two go to wireless tree? If yes, please assign the patches
> to me on patchwork. But rtw tree is fine for me as well, your call.

For most distro, other drivers select this flag, so not urgent to have these
two patches. Then they will go via rtw tree. Thanks.
Ping-Ke Shih July 31, 2024, 5:46 a.m. UTC | #3 
Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Zong-Zhe Yang <kevin_yang@realtek.com>
> 
> We have invoked device coredump when fw crash.
> Should select WANT_DEV_COREDUMP by ourselves.
> 
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

2 patch(es) applied to rtw-next branch of rtw.git, thanks.

7e989b0c1e33 wifi: rtw88: select WANT_DEV_COREDUMP
d523dc49d13e wifi: rtw89: select WANT_DEV_COREDUMP

---
https://github.com/pkshih/rtw.git
Kalle Valo July 31, 2024, 8:39 a.m. UTC | #4 
Ping-Ke Shih <pkshih@realtek.com> writes:

> Kalle Valo <kvalo@kernel.org> wrote:
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
>> >
>> > We have invoked device coredump when fw crash.
>> > Should select WANT_DEV_COREDUMP by ourselves.
>> >
>> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>> Should these two go to wireless tree? If yes, please assign the patches
>> to me on patchwork. But rtw tree is fine for me as well, your call.
>
> For most distro, other drivers select this flag, so not urgent to have these
> two patches. Then they will go via rtw tree. Thanks. 

Makes sense, thanks.
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/Kconfig b/drivers/net/wireless/realtek/rtw88/Kconfig
index 22838ede03cd..02b0d698413b 100644
--- a/drivers/net/wireless/realtek/rtw88/Kconfig
+++ b/drivers/net/wireless/realtek/rtw88/Kconfig
@@ -12,6 +12,7 @@  if RTW88
 
 config RTW88_CORE
 	tristate
+	select WANT_DEV_COREDUMP
 
 config RTW88_PCI
 	tristate