| Message ID | 20240820101216.355012-3-arend.vanspriel@broadcom.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | dt-bindings fixup for brcm,bcm4329-fmac.yaml | expand |
On Tue, Aug 20, 2024 at 12:12:16PM +0200, Arend van Spriel wrote: > Align with the corrected device tree bindings in brcm,bcm4329-fmac.yaml > which imposes a constraint that the compatible should have the string > "brcm,bcm4329-fmac". Additionally, please explain why do you think these devices are compatible and also how this change affects working. Considering that previously these devices were not matched by brcmf_of_probe() and now they will, this is significant change. > > Fixes: e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties & chips") No, no bug to fix. Previous code was intentional. If you claim there is a bug, please explain what exactly is being fixed. > Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi index 5988a4eb6efa..4b021626d469 100644 --- a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi +++ b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi @@ -72,7 +72,7 @@ hpm1: usb-pd@3f { &port00 { bus-range = <1 1>; wifi0: network@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 00 00 00 00 00]; diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts b/arch/arm64/boot/dts/apple/t8112-j413.dts index 6f69658623bf..df2a63d8dd5e 100644 --- a/arch/arm64/boot/dts/apple/t8112-j413.dts +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts @@ -43,7 +43,7 @@ led-0 { &port00 { bus-range = <1 1>; wifi0: wifi@0,0 { - compatible = "pci14e4,4433"; + compatible = "pci14e4,4433", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 10 18 00 00 10]; diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts index 0ad908349f55..5f3453e109b8 100644 --- a/arch/arm64/boot/dts/apple/t8112-j493.dts +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts @@ -43,7 +43,7 @@ led-0 { &port00 { bus-range = <1 1>; wifi0: wifi@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 00 00 00 00 00];
Align with the corrected device tree bindings in brcm,bcm4329-fmac.yaml which imposes a constraint that the compatible should have the string "brcm,bcm4329-fmac". Fixes: e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties & chips") Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> --- arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)